Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Julien,

On 03.12.2021 13:05, Julien Grall wrote:
> Hi Michal,
> 
> On 03/12/2021 09:58, Michal Orzel wrote:
>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>> forgot to modify a comment about lr_pending list,
>> referring to a function that has been renamed.
>> Fix that.
>>
>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
> 
> The format for fixes tag is a 12 characters sha1 followed by the commit 
> message. In this case, it would be:
> 
> Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq")
> 
> I can fix it on commit.
Please do. I forgot about this requirement.
> 
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>> ---
>>   xen/include/asm-arm/vgic.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>> index e69a59063a..ade427a808 100644
>> --- a/xen/include/asm-arm/vgic.h
>> +++ b/xen/include/asm-arm/vgic.h
>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>        * corresponding LR it is also removed from this list. */
>>       struct list_head inflight_irqs;
>>       /* lr_pending is used to queue IRQs (struct pending_irq) that the
>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>>        * no LRs were available at the time.
>>        * As soon as an LR is freed we remove the first IRQ from this
>>        * list and write it to the LR register.
>>
> 
> Cheers,
> 
Cheers,
Michal