Re: [PATCH] xen/arm: Do not include in the image functions...

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 06/12/2021 14:19, Michal Orzel wrote:
> vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
> CONFIG_NEW_VGIC is not set.
>
> enter_hypervisor_from_guest is protecting calls to these functions
> with CONFIG_NEW_VGIC but their definitions and declarations are not > 
> protected. This means that we are including them in the image even
> though we are not making use of them. Fix that.
While I agree, they are only used by the new vGIC, the implementation of 
the functions are not. So I don't think they should be protected by 
CONFIG_NEW_VGIC.
Actually, I am not convinced they should be protected. But I guess you 
did that for a reason. Would you be able to clarify what is your reason?
Cheers,

--
Julien Grall