[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch V2 24/36] powerpc/pseries/msi: Use MSI device properties
- To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- From: Jason Gunthorpe <jgg@xxxxxxxxxx>
- Date: Wed, 8 Dec 2021 11:51:18 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s348dqgICSc7yc8kd+csRUb+Z7Y5Qb2f67t8v+cpqVA=; b=Xn7+yNcgsexG4ZNFuUU8o6XmsOMndZaItMfL8fnKmJyB7fMeE6rD4a96TKohqhtyNATFMukfquFeH94d7vWsiPlz27A82XU52K9u45ZQKdd9qReR4BXP4uqXg9fvWia1XAyeEE/rL2q4TvVnVRNY3fY8ZRZuiiGv1T4XMUSAcJ1NfxL+FvnKUgjkd229aeRfOqlluRKciiOeY6Le+6bmwbc8HlQoGoIUl/hR5m53K0LNoSRTobZa3AksD2ReQmkMHJ1P4MgQIiqc3zi+OraVrx+WOmtM5YGKpWw3+40Uf53vDbPI6+EAkZ1vtwpM2KXXA29+TFbw0F15uvoV7LZBbg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kY0G6Zm47GMAJceB2SGeMH4IoTa7S7djXvm0vi1zJH1G1anxJKI2S4kaZyB8iY+2lcjO7O266m2Ibo8vxRkHr+8Cul/fIJRzO7G1TiohAszV+2iwB1x2UGYrjaGZ/cOW67HAP/qcNQuJs8behChEGfxzbDKb2DAfjbP3G1UfHS+ZmVa/ztJHcfU2J4dhSu3q1laoS8GJwbdTa40G625fUplqxzf3k6Q/i7j6yT2JdQTTOvdBPSJIvwlxl7xaX4IyFfKV8S/gibTVkUsauUlXOJua026CuRnDDSfX+0Nqm+JSLrTto7U/7DcP0pULYVWwypesEzbs5JrqzixcNEBs7A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
- Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Bjorn Helgaas <helgaas@xxxxxxxxxx>, Marc Zygnier <maz@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Megha Dey <megha.dey@xxxxxxxxx>, Ashok Raj <ashok.raj@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Cedric Le Goater <clg@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Santosh Shilimkar <ssantosh@xxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, Stuart Yoder <stuyoder@xxxxxxxxx>, Laurentiu Tudor <laurentiu.tudor@xxxxxxx>, Nishanth Menon <nm@xxxxxx>, Tero Kristo <kristo@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Sinan Kaya <okaya@xxxxxxxxxx>
- Delivery-date: Wed, 08 Dec 2021 15:51:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Dec 06, 2021 at 11:39:34PM +0100, Thomas Gleixner wrote:
> instead of fiddling with MSI descriptors.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> arch/powerpc/platforms/pseries/msi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> +++ b/arch/powerpc/platforms/pseries/msi.c
> @@ -447,9 +447,9 @@ static int rtas_prepare_msi_irqs(struct
> static int pseries_msi_ops_prepare(struct irq_domain *domain, struct device
> *dev,
> int nvec, msi_alloc_info_t *arg)
> {
> + bool is_msix = msi_device_has_property(dev, MSI_PROP_PCI_MSIX);
> + int type = is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
> struct pci_dev *pdev = to_pci_dev(dev);
We have the pci_dev here, why not just do something like
bool is_msix = pdev->msix_enabled;
?
Jason
|
