[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping: [PATCH] x86/EPT: squash meaningless TLB flush
- To: Kevin Tian <kevin.tian@xxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Dec 2021 10:32:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7CeQ6U9qkYLcuHRR0iukM37EAFT/0aM4VwLDK2b7IBI=; b=jJ0CfdJz2L59X7lHL9C+GgjZS2J+igHlXn2BY/nCYMKOzK9xM9zPXxhPlg0QWpnnQ0on8ZghIOUlFHO8Aoc1UfvSIlNGen4OxeyVu6UKKQXENXWrFK9EDg6mke+xnZVPrcnvi5bFXYISCykCgPptw0Q4bzRX2siD+99iCj8aoJxo571HtmoaAzCWUvtsjJrve5D2U1iRbtWnhVrIJPEcY9P+HEVnlV6rrrqx6yNqc8ol0lDxQC1sGZpOiD1rnvDkl0U2FlPQUPzUTGgPwwa1kx67sgeAi9CCsm4KFuZ/t+bZtZo6mO8Y+nAzJttTJ/iqXh1NpW5fcJreMayKvBvdxg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AE1SHNj4Oqca6u05qxy3UNVa6mUwgNIyARdVALjUu1aOhBRTpMkiliwhOcxrHicG7XLtShVJjOUUIbn8p+4A8NrP9oYT2xQpoCTx2IeFLFLV2J9wcsi79/PWfZ3G77S/zI3uIvCn0EE5mWpzVHWLQnyvwvGD4pduUtanDxe8Hm9lKcRhSn3qDunjKxUWf++Q6ioOoz+Y28LSY4TOLO/1tgj0VlBNbAo88iBur7I5DYAk8fpVdHKT3H8Tt0amjsFhACrSuI33GBYje5SjCnDwBSNSJh/SK7e8mPR1Yf45TAWjz991jcaoc0W6LUwDsjNgDwWaDmBM0V+bK3juJ8GB0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 10 Dec 2021 09:32:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.11.2021 17:10, Jan Beulich wrote:
> ept_free_entry() gets called after a flush - if one is necessary in the
> first place - was already issued. That behavior is similar to NPT, which
> also doesn't have any further flush in p2m_free_entry(). (Furthermore,
> the function being recursive, in case of recursiveness way too many
> flushes would have been issued.)
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
May I ask for an ack or otherwise here? From all I can tell I have addressed
Andrew's comment.
Jan
> --- a/xen/arch/x86/mm/p2m-ept.c
> +++ b/xen/arch/x86/mm/p2m-ept.c
> @@ -246,8 +246,7 @@ static void ept_free_entry(struct p2m_do
> ept_free_entry(p2m, epte + i, level - 1);
> unmap_domain_page(epte);
> }
> -
> - p2m_tlb_flush_sync(p2m);
> +
> p2m_free_ptp(p2m, mfn_to_page(_mfn(ept_entry->mfn)));
> }
>
|
