[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch V3 01/35] PCI/MSI: Set pci_dev::msi[x]_enabled early
- To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- From: Jason Gunthorpe <jgg@xxxxxxxxxx>
- Date: Mon, 13 Dec 2021 09:37:35 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xggFXRr0LsROw2d6Z61nZ7hHVxM38Z13f0KEkB/Uhw4=; b=LQI9zQrgi8BymOvVzFpv1YQx4Mn+ONoD7weq7u3udebHW2dqNlHqmwe011BFI0KH0+7JSFapNgMcIQrO3qu5SxyLiTw5xHz4Ahm6kAZqfvKZv+vHs3xdH+Q2IpfoCHQJUkKLbYpmLYlSK9OTkgzCCpudMjeZvvu4EfESI4WQi/2Kmst4Lf+iz2P79hFNWSnAxObHJX2vlOhC3dM0AH5PXb82HrbyWyLiB7QftLIzhrYcOqokCiHICKDjmP0iu6K61mhKT+Z++1u0SXBeQOX0xjk87Vp5S57NUQ+3QAXJ0QcGEFECuWnale2HGWxcGXPwRKDeBjL7Tm/f7dxkAsz73w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ki5BN33Ic7DMxipuaQkKgWuddBouHcbm9iDqcVZrR56znv0141dDiHveqC2MxsMYUQn6UkM4NoBmSWVFIR1tqVb+4jbwzRMcunlGkw0o504hq2PNdWd4p7pQON7B8ITZl9IsDKWMVDSlDWe317IiwsUe2TYPhc0d2SAwsEfb+Vc2l3m3+iJsvbhTCQdg369sZjv3mWnQbw0VhYWg0NpwOIusTXsOB3s7c663R3oad1clj46XagEeZYigzjHBpl9Rp7fayl+9IhMbPwe658J7UjH8KNpwLMJGar3NOW8SHpC5beufAo6VYJssr8P/qrSXgHPWPKbJ8Ir74qV8h8ei3A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
- Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Bjorn Helgaas <helgaas@xxxxxxxxxx>, Marc Zygnier <maz@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Megha Dey <megha.dey@xxxxxxxxx>, Ashok Raj <ashok.raj@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Cedric Le Goater <clg@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Stuart Yoder <stuyoder@xxxxxxxxx>, Laurentiu Tudor <laurentiu.tudor@xxxxxxx>, Nishanth Menon <nm@xxxxxx>, Tero Kristo <kristo@xxxxxxxxxx>, Santosh Shilimkar <ssantosh@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, Mark Rutland <mark.rutland@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Jassi Brar <jassisinghbrar@xxxxxxxxx>, Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>, Sinan Kaya <okaya@xxxxxxxxxx>
- Delivery-date: Mon, 13 Dec 2021 13:38:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Dec 10, 2021 at 11:18:44PM +0100, Thomas Gleixner wrote:
> There are quite some places which retrieve the first MSI descriptor to
> evaluate whether the setup is for MSI or MSI-X. That's required because
> pci_dev::msi[x]_enabled is only set when the setup completed successfully.
>
> There is no real reason why msi[x]_enabled can't be set at the beginning of
> the setup sequence and cleared in case of a failure.
>
> Implement that so the MSI descriptor evaluations can be converted to simple
> property queries.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> V3: New patch
> ---
> drivers/pci/msi/msi.c | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
Jason
|
