Re: [PATCH v3 01/13] xen: move do_vcpu_op() to arch specific code

[Juergen Gross <jgross@xxxxxxxx>]

On 14.12.21 18:21, Julien Grall wrote:
> Hi Juergen,
>
> On 08/12/2021 15:55, Juergen Gross wrote:
> > Today Arm is using another entry point for the vcpu_op hypercall as
> NIT: The 'as' doesn't sound right here. Did you mean 'compare to'?
Hmm, it should even be "different" instead of "another". And then it
should be:

  The entry point used for the vcpu_op hypercall on Arm is different
  from the one on x86 today.

> > x86, as some of the common sub-ops are not supported on Arm. The Arm
> > specific handler filetrs out the not supported sub-ops and then calls
> Typo: s/filetrs/filters/
Yes.

> > the common handler. This leads to the weird call hierarchy:
> >
> >    do_arm_vcpu_op()
> >      do_vcpu_op()
> >        arch_do_vcpu_op()
> >
> > Clean this up by renaming do_vcpu_op() to common_vcpu_op() and
> > arch_do_vcpu_op() in each architecture to do_vcpu_op(). This way one
> > of above calls can be avoided without restricting any potential
> > future use of common sub-ops for Arm.
> >
> > Additionally the single user of HYPERCALL_ARM() can be modified and
> > HYPERCALL_ARM() can be removed.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature