Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 15/12/2021 07:49, Jan Beulich wrote:
> On 14.12.2021 18:05, Julien Grall wrote:
> > On 25/11/2021 13:39, Anthony PERARD wrote:
> > > For two reasons: this macro is used to generate a "linker script" and
> > > is not by the linker, and name starting with an underscore '_' are
> > > supposed to be reserved, so better avoid them when not needed.
> > If that's the case, then shouldn't we also rename __ASSEMBLY__?
> I'd rather not - unlike __LINKER__ (afaict at least) __ASSEMBLY__
I can't remember where I took __LINKER__ from.

> is a commonly used identifier (which we've actually inherited from
> Linux)
Fair enough.

Cheers,

--
Julien Grall