[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] x86/cpuid: Split dom0 handling out of init_domain_cpuid_policy()
- To: Andrew Cooper <amc96@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 16 Dec 2021 17:51:52 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Q9OXD/V6ENbTcfIZntNoC/5RQhsoM1AKICGpX+iqrM=; b=lCAhNU2SJWz6wd87kk2bcB1K33V6mX5VfB2IMKCHECkv4NwmTjI8rhNQPIAQdLNU+NP3MxzuzHNz9l/L9g3PIZrJ3/zRTHK4NO6jq2vAJJy5PNczxUsm2smt+IUjC15TXhaOJcBlS1Qqw41galh5v6DkQUoddF1cvZKPBob1D+6rUf5T8LoMrzk1LMUd1vTWtCUk/L67PFh+GAMUyE4qbDavRAg8sBqpdGQLpD2J8KlQlglLR7sxSrYQvjsAa07Ig6c0L2eGXQ0crR/ttITjN4HJ13sLAGN55GxR+7HJKVIV8Y+z9l/m/U3mtGLgQkqqFtFosbqbTsKdbqGjuJ0c9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0ndosO4lWNpgfcJFQWnkwg8DaTAwbO5U3avPgo6ceAUZwqYaJJ5gDnCjrDiRH6Sa8p1BN1M3qaVs3FrKUaTW9LDdghiw7eake4kvKMIlZAY0HJi94Hn3lzr4awWJPEXVqM3000XAS5oG8+KGL4938y35feoyNRVP8zdTSQeAHp3qafzMvCYb5Nhnx/kfueGfSPebk/CGGxU8P3Ur2mKngjp2ivomXZ2K7eMRPv/cPQzVeo+H0EhjPtyu9awpHrAX4ND1XBqYJBb9+YNmSh+raT2BdQVUMTC9UfhVt83x2OAlLWPw9Qpo0u5gW2arGyAjAywYEmtadzsGtO8LFDqHw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 16 Dec 2021 16:52:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.12.2021 17:41, Andrew Cooper wrote:
> On 16/12/2021 16:38, Jan Beulich wrote:
>> On 15.12.2021 23:21, Andrew Cooper wrote:
>>> To implement dom0-cpuid= support, the special cases would need extending.
>>> However there is already a problem with late hwdom where the special cases
>>> override toolstack settings, which is unintended and poor behaviour.
>>>
>>> Introduce a new init_dom0_cpuid_policy() for the purpose, moving the ITSC
>>> and
>>> ARCH_CAPS logic. The is_hardware_domain() can be dropped, and for now there
>>> is no need to rerun recalculate_cpuid_policy(); this is a relatively
>>> expensive
>>> operation, and will become more-so over time.
>> Would you mind leaving it there in a commented out form, hinting at when
>> it may need re-enabling?
>
> Leave what? The recalculate_cpuid_policy()? That comes back in later
> in the series.
I've meanwhile spotted it, yes. Let's hope its conditional invocation
there makes clear enough that with certain other changes it may also
be needed.
Jan
|
