[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- Date: Thu, 16 Dec 2021 17:36:26 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G+/XOKd7wnHe2drRKI7fLT7N1/71vl1GnG/k+ljNB1E=; b=D7OQ724V3I474IHxqF6ata5/ACQzMF3GTv7JW2R/zfl7utYH0xFJtLGZ8VbOkZXC4RU5Lb52zf3FoF6xdRk/WXlbyeFxc8stloKpzZcrUEHF7EQiqXpjlJxdnzHus1S3wnrB425RCNG95hMw59PCGuGO94buFLUZxQGlltFHOKddvmlWio/oqEsr2sLVXFtNiDf4YPUwjxwdJ3BNsF8GBoYiV10eKPo755GFy8TW77tmwNSrQE4qisyqnXyejDga7kpZp1hu6sYR//YKNvHPC/SZmdqgEgioFN73QIKnUeQnAaAsENNdz2nWDNftrM/KheR7594gDyqFHSFl4yrf3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ito8HJK5VA8sfgX7n+QjP6UPNDTfrjneJGzA90jgqK3zOvg7xYRn5GwjdR/tzHcaRH6MppMhNfd9Tv0CBNH1EFHfSnwcwZxcyUS/bu+tidoiWpqybzqNoeAzjLljYyme0NrYHkqcxLkGSoh1Af0GDSB/cmdNKvJYD2DS1rDdsV+OMatK4lSTJuKTpRl5IVjrWFj26iqz7VMycZwNjjTM3vMA5Q+14iDmqEpDfaq/7T4TDdQXx4uLaXLCDQTgb79t3D0WUT2+TSVMVpTW6n9HzZh5LBTWXw1tbYrfl4AU2JPWGs/fi3B/Agbs06GPMRPtDNZgxqoe2m+KOENQxzaboQ==
- Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 16 Dec 2021 17:36:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX8M3LpzWz4l8PQUiIA2nAUV0H+qwxu+8AgAOpWoA=
- Thread-topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Hi Jan,
On Tue, Dec 14, 2021 at 10:41:30AM +0100, Jan Beulich wrote:
> On 14.12.2021 10:34, Oleksii Moisieiev wrote:
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
> > #define XEN_DOMCTL_vmtrace_get_option 5
> > #define XEN_DOMCTL_vmtrace_set_option 6
> > };
> > +
> > +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> > +struct xen_domctl_sci_device_op {
> > + uint32_t size; /* Length of the path */
> > + XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> > +};
>
> This being - aiui - Arm-only, please enclose it by respective #if,
> just like we do for certain x86-only ops.
>
I agree. I will add #ifdefs in v2.
> I'm further afraid the term "SCI" is ambiguous with ACPI's System
> Control Interrupt, so there's some further tag needed in the names
> used here.
>
Thank you for remark. I'm thinking about SC as System Control.
What do you think?
> Finally please make padding explicit and check that it's zero on
> input.
>
I will align the comments in functions and structures in v2.
Best regards,
Oleksii.
|
