Re: [XEN PATCH 25/57] tools/examples: cleanup Makefile

[Andrew Cooper <amc96@xxxxxxxx>]

On 06/12/2021 17:02, Anthony PERARD wrote:
> diff --git a/tools/examples/Makefile b/tools/examples/Makefile
> index 14e24f4cb3..48b520e133 100644
> --- a/tools/examples/Makefile
> +++ b/tools/examples/Makefile
> @@ -26,10 +22,8 @@ uninstall: uninstall-readmes uninstall-configs
>  
>  .PHONY: install-readmes
>  install-readmes:
> -     [ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
> -             $(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
> -     set -e; for i in $(XEN_READMES); \
> -         do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
> +     $(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
> +     set -e; for i in $(XEN_READMES); do \
>           $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \

Hmm.  Do we need a shell loop here at all?  Can't $(INSTALL_DATA) take
multiple $i's at the same time?

~Andrew