Re: [PATCH] tools/xenstore: drop support for running under SunOS

[Andrew Cooper <amc96@xxxxxxxx>]

On 17/12/2021 07:50, Juergen Gross wrote:
> Since several years now xenstored is no longer capable to run under
> SunOS, as the needed libxengnttab interfaces are not available there.
>
> Several attempts to let the SunOS maintainers address this situation
> didn't change anything in this regard.
>
> For those reasons drop SunOS support in xenstored by removing the SunOS
> specific code.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

FWIW, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> -out:
> -     /*
> -      * 6589130 dtrace -G fails for certain tail-calls on x86
> -      */
> -     asm("nop");
> -}

Code like this makes me extra sad... It only works for the same reasons
as why asm ("") would be fine as well.

~Andrew