[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 12/47] build: build everything from the root dir, use obj=$subdir
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 20 Dec 2021 11:29:49 +0000
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "Ross Lagerwall" <ross.lagerwall@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 20 Dec 2021 11:30:14 +0000
- Ironport-data: A9a23:IUXO16zN5cw5YPh9+6R6t+f3wCrEfRIJ4+MujC+fZmUNrF6WrkUGz 2dOXTrXP6yINzCmKop3YYq28h4GuMPTn98ySApo+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbRh2tcAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+t4z 99StJKzcgEoDPWWiudDbQZZMT4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JgSRKaCO pVxhTxHTDL4cSxzB1ArUp89wc2agWL5XRxZpwfAzUYwyzeKl1EguFT3C/LefdqMQsdZl1iZv UrJ+m34BlcRM9n34TOB82mwj+7V2y3hUYQZFaaQ6fJhxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM GQd4C9opq83nGSoSd/nVhH+v3+AvTYbQdNbF+B84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YX6F7bKVsTOaMDAYN3MffjQDSRYZ4t7lu8c4iRenZtpsHKO6lNTdBSD7w zfMqjM3wboUk6Yj1rq51UDKhSq2oZrERRJz4R/YNkqv6QlzdYO+Z4il7FHdxflFJYedCFKGu RAsmcKT8eQPBpGljzGWTaMGG7TBz/SYNDzRh3Z/Ep9n8C6ik1adeoRX7CB7NV1eGM8Ocj/0Y 2feoQpUopRUOROCcqtfc4+3TcMwwsDIDs/5X/rZat5PZJlZdwKd+ixqI0mK0AjQfFMEyP9lf 83BKID1UChcWf8PICeKq/k16rYszD8/y2DoQ5HJl0610uSge3+3VuJQWLeRVdwR4KSBqQTT1 t9QMcqW1hlSONHDjjnrHZ07dg5TcyVibXzig4kOL7PYfFI6cI00I6aJmetJRmBzo0hCeg4kF FmZU1QQ9lfwjGavxe6iOiE6M+OHsXqSQBsG0c0Q0bSAhiFLjWWHtv53m34LkV4PrrML8BKMZ 6NZE/hs+9wWItg9xxwTbIPmsKtpfwmxiASFMkKNOWZkLs87FlCXpIW1IWMDERXi6QLt6qMDT 0CIjFuHEfLvuSw/ZCopVB5f5wzo5iVM8A6Dd0DJPsNSaC3RHHtCcETMYgsMC5hUc33rn2LCv y7PWEtwjbSd8ucdrYiS7YjZ/tjBLgeLNhcDd4Utxe3tbneyE6vK6dIobdtkihiBDj6po/v7O r0Opxw+WdVe9Gt3X0NHO+4D5coDCxHH/de2FyxoQyfGaUqFELRlLiXU1MVDrPQVlLRYpRG3S gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRkANRe7lyEAfqB+N5kow Ll9tZdOuRC/kBcjLv2PkjtQqzaXNnUFXqh+7sMaDYbnhxAF0FZHZZCAWCb67IvWM4dHM1UwI y/Sj63H3uwOyk3Hens1NH7MwesC2she5EEUlAcPfg3blMDEi/k72Axq3Q42FgkFnA9a1+9TO 3RwMxEnL6u54Do11tNIWHqhGl8dCUTBqFDx0VYAiEbQU1KsCj7WNGQ4NOuAoBIZ/mZbcmQJ9 b2U0j+4AzPjfcW31SouQ0917ffkSIUppAHFncmmGeWDHoU7PmW50vP/OzJQpku1G941iW3Gu fJurbR5ZqDMPCINp7E2VtuB3rMKRRHYfGFPTJmNJk/S8b0wrN1q5QWzFg==
- Ironport-hdrordr: A9a23:mOS0aaqObfW3FQoypBFVsOUaV5oWeYIsimQD101hICG9JPbo8f xG/c5rtyMd6l4qMk3I9ursBEDtex/hHP1OkOos1NWZPTUO41HYS72KhLGKq1bd8kvFmdK1vp 0BT0ERMrPN5fcRt7eC3OEVeexQpeVuUcqT9IPj80s=
- Ironport-sdr: 3QrXlcC0EBd1phBKZ1jkitkQhhyZngPjit6JiCph5yVSqWel5MQOa7BGWrjdg3t8BCCb0N2a1B dNX9v2FFCB8T+XppA2stuX5MNL7MDcJCaRvCbkluRvU5jnEBBP+qcpLyCjYqp7+TRksBKPC2YL z4X3WkwzCoWu0KlYkxsaCpAdlKv5gstZVKydJnu/rMcdudOSVemwWyJhsqfOWM+j4yFo0qRh7d L8TzhwW2VuP9eeH45qhhVGFh9zQ8pwiWPOdLzICnveJceDyDgXy4uM0Zp34IjlqrZ/Kdapg0pm iBqChNrHKKaJgwNgzbyG5adm
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Dec 16, 2021 at 11:08:47AM +0000, Anthony PERARD wrote:
> On Tue, Dec 07, 2021 at 12:10:34PM +0100, Jan Beulich wrote:
> > On 25.11.2021 14:39, Anthony PERARD wrote:
> > > --- a/xen/Makefile
> > > +++ b/xen/Makefile
> > > @@ -22,6 +22,15 @@ export CHECKPOLICY ?= checkpolicy
> > > export BASEDIR := $(CURDIR)
> > > export XEN_ROOT := $(BASEDIR)/..
> > >
> > > +abs_objtree := $(CURDIR)
> > > +abs_srctree := $(CURDIR)
> >
> > Nit: In line with e.g. obj-y I think these would better be abs-srctree and
> > abs-objtree.
>
> I guess that would be fine, we don't need to keep the same spelling that
> Kbuild does.
Actually, those two variables are exported, as it appear in the next two
lines. Exporting a variable with a dash doesn't work very well as shells
may not be able to use them. When make find a variable with a dash in
it in the environment, it unexport them.
So, for those two variable, we need to avoid using a dash, so I think
keeping the current name is better. (And now, I've find out that there's
an issue in the build system, I'll prepare a patch.)
Cheers,
--
Anthony PERARD
|
