Re: [PATCH v2 04/10] mini-os: respect memory map when ballooning up

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Juergen Gross, le lun. 20 déc. 2021 17:07:10 +0100, a ecrit:
> +unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long 
> pages)
> +{
> +    int i;
> +    unsigned long end;
> +
> +    for ( i = 0; i < e820_entries && e820_map[i].addr < (pfn << PAGE_SHIFT);

Shouldn't that be addr+size? Otherwise if pfn is in the middle of an
e820 entry, we will miss picking up that.

> +          i++ )
> +    {
> +        end = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> +        if ( e820_map[i].type != E820_RAM || end <= pfn )
> +            continue;
> +
> +        return ((end - pfn) > pages) ? pages : end - pfn;
> +    }
> +
> +    return 0;
> +}