[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
- To: Rahul Singh <Rahul.Singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Dec 2021 09:04:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OvJZFlFi7ZP8SdU97BHY6Lhk82xfcB05gFJe5Gp1YB4=; b=LwbE+Oz7kzOwb+DMltYcM4FH1/GSeoTBGGVngYcqv/EajsIrjR/TMgKwIzuMUC4TsGOXdocQHKWtuS2AmdNEdK2wSYkjIlJP3n5aSitT1iRkJJmARh/VpaCjmFb9zfI2Jht0OAaairMgo28YYycVrrvo/yWslA1RPHhQtz7/2Wlcre9dvHYd52rEoStc9sHSixb/jHjm/5QMKQ3mESrz0x2+3zDpJxuR4cZ2wjtCY52rHUigojDV50MSzw5t61hUlDYJT0eW/q2tizYlxpWA2jZpgSebCrrB6DE4VkREW7RuZB4nVmZaQxGz2UundpfZjcUzWGatisppEBb0cQiSog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksJHr7zi3j30dnzo4sCcxg98S4MSHSfD22x8QMbhDF6pjDbShETYon25VRAMjS5Xdm8U0Z+GooyX4t5bb4Znf+1WqjcVSd9UgzrSfFvoCtee+cHkmT2g6XFzEaBmMB1HieKk6EpmwlkQTq0A5Fos8nqtNnDtEtfP4pjIyw82bP6brwD/0AbQ5gPeH4ExHJI8EutTbZjTiHw8U3eGOSknWcS5iWqac1ip+WGXNbth9ROSgBZ89Zyyyjt/htlHKXLP8jHfqaIAEW0J6GaQDX5psOBcpfp0GY3cIBbPJFqIms79ax2+KNQz3PubuFt1JcJnG+QmbDm8hrAk7eBLJOGTAQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 21 Dec 2021 08:05:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.12.2021 12:30, Rahul Singh wrote:
>> On 24 Sep 2021, at 10:53 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> Having a separate flush-all hook has always been puzzling me some. We
>> will want to be able to force a full flush via accumulated flush flags
>> from the map/unmap functions. Introduce a respective new flag and fold
>> all flush handling to use the single remaining hook.
>>
>> Note that because of the respective comments in SMMU and IPMMU-VMSA
>> code, I've folded the two prior hook functions into one. For SMMU-v3,
>> which lacks a comment towards incapable hardware, I've left both
>> functions in place on the assumption that selective and full flushes
>> will eventually want separating.
>
>
> For SMMUv3 related Changs:
> Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Thanks. Any chance of an ack / R-b also for patch 3?
Jan
|