[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] tools/libxl: Mark pointer args of many functions constant
- To: Elliott Mitchell <ehem+xen@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 5 Jan 2022 10:09:43 +0000
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 05 Jan 2022 10:10:19 +0000
- Ironport-data: A9a23:FdsW9qNZoqetQ//vrR12kMFynXyQoLVcMsEvi/4bfWQNrUp31jdWm jEfCGGEO6reMWH1fd0nbYSzo01VuZ+DxtU3Gwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En150Eo+w7dRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxWTvMkul oUdj7nzEiF0Ao7ut+oydQYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm5q2ZsSQqu2i 8wxcgZwNU7daRh2B3xMWcohnv6o2kDnbGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6aq XjB5H/RGQwBOZqUzj/t2n+si+qMjS79cIdPDPuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySWosLVBkPi5iTe51hFBoQWQ7ZSBByxJrT8wxy6HzdaHm57TZ99kpIKZh4F2 HCvgIa8bdBwi4G9RXWY/7aSiDq9PykJMGMPDRM5oRs5D8rL+99q0E+WJjp3OOvs14CuR2msq 9yfhHVm74j/m/LnwElSEbrvpzu37qbEQQcujuk8djL0t1gpDGJJimHB1LQ60RqiBNrJJrVil CJd8yR70AzoJcrT/MBqaL9XdIxFH97fbFXhbadHRvHNDQiF9X+5Zpx36zpjPkpvOctsUWa3P BaI41oBvcEJYCXCgUpLj2SZUJpCIU/IT4+NaxwpRoAWPsgZmPGvoUmCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNEiU5GHeegvp6pdynnpW7TqKHfjTlk37uZLDNC/9YepUazOmM7FmhJ5oVS2Iq r6zwePRkE4BOAA/CwGKmbMuwacicSJmWMuo8pMPLYZu4GNOQQkcNhMY+pt5E6QNokifvr6gE qiVVhAKxVzhq2fALAnWOHlvZKm2BcR0rG4hPDxqNlGtgiBxbYGq5aYZVp02Ybh4q7Azka8qF 6EIK5eaH/BCajXb4DBBP5Pzm5NvKUawjgWUMiv7PDVmJ8x8RxbE88PPdxf08HVcFTK+sMYz+ uXy1g7STZcZaR5lCcLaNKCmw1+r5CBPk+NuRUrYZNJUfRy0ooRtLiXwiN4xIt0NdkqflmfLi V7ODE5B9+fXooIz/N3Yvoy+rt+kQ7lkA05XP2jH9rLqZyPUyXWunN1bW+GScDGDCG6toPe+Z f9Yxu3XOeEcmAoYqJJ1FrtmwP5s59broLMGnA1oEG+SMgauA7JkZHKHwdNOputGwboA4Vm6X UeG+997P7SVOZy6TA5NdVR9NunTh+sJnjTy7OguJBSo7SB6y7OLTEFOMkTekydaNrZ0bNsoz OpJVBT6MOBjZs7G6uq7sx0=
- Ironport-hdrordr: A9a23:zi6elqHor382075qpLqE7seALOsnbusQ8zAXP0AYc3Jom+ij5q STdZMgpHjJYVcqKRQdcL+7VZVoLUmxyXcx2/h2AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IOceEYZmIasS+V2maFL+o=
- Ironport-sdr: EYSsd1DylTSc2aP11lq0xMy6HJgAUEIBFqIOlrLdPX2OYyZaMGu9q/FZDazQ6vhqyvhYloLTCZ f4FnleWWaTTDTxnZtoCtG5Y+rlwjHTKykoU/zUKtqeLBvlg1r64aA3DJQ7oL0Jom+T+H67I/JW P2z/1cSeV499+NlLxxuNaVgttu+nVK5EAjojQGxPO3W+ZZnLw41LfwUuT3Hu4bBFOCQ6a01Hrs 1MlkCmufEyuH5lEA0CT9c5VSWzseHg2gmrwQoXEKsuWz49nUHBDnBB10M+ZgKX2gyCL34VUdI/ h0Jiw8gp70rHTLQB4OwEiVJj
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Dec 18, 2020 at 01:37:44PM -0800, Elliott Mitchell wrote:
> Anything *_is_empty(), *_is_default(), or *_gen_json() is going to be
> examining the pointed to thing, not modifying it. This potentially
> results in higher-performance output. This also allows spreading
> constants further, allowing more checking and security.
>
> Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
This patch doesn't build.
libxl_cpuid.c:510:17: error: conflicting types for
‘libxl_cpuid_policy_list_gen_json’
510 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from libxl_internal.h:89,
from libxl_cpuid.c:15:
/home/sheep/work/xen/tools/libs/light/../../../tools/include/libxl_json.h:30:17:
note: previous declaration of ‘libxl_cpuid_policy_list_gen_json’ was here
30 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Also we talked about this patch before, in
https://lore.kernel.org/xen-devel/YImXfc4oaPgWzkeT@perard/
Cheers,
--
Anthony PERARD
|
