[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] build: correct usage comments in Kbuild.include
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 12 Jan 2022 12:28:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+kSn5agg05bTqYmtz/grnEHvxM7HKRHO0hkeaCRsUrw=; b=GCR7fem5iE6Azt+7sQcQACu/CIP+DjUeqlvhRWE4ufxwfDQx2q+zYS3Y1215scoAIMrVjo0KZrnzUcnuSjKyEEj4U8UtONRDPzRyIX0UY0BY+k0cwcvM+ocWcA4DX+o7QfAxNqUve2D3Ylv1ioeU3Of5tf+DCENY55GZG/nGh+otgUAZ6pxW7ZqNrSEwAIvvmhj8t49uC5HIfYOYSATFObQFgzlKkDvqJ7P/Eegsf42+vbk8g60TIUHvnngq8H0vYvIDQZ9Z3pTbKxAS1Jd0BJuqDaIH6roJBh+WJahcomG90qzemzXkznDrXIRjNxB3Y4iHkGdjO1XBJsivNx+9Mw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IF7LnbhI3kVaO0cm9lwGiTh+TTdDiy+qRBQ95bxRdtRkgszml8uyT45T4NuN1k8Xe/QHA5hdadUi+q5D+XHZ0exvlCslj9C3ySXF7T4yFQ1SGHdxhP8QeeMh113LKJSuHSz1NMMOy3BfYuIdn4CWkejJ1hrrf6ZJkBPEtJaVaJqmJo2YEdSjMgFZZb+dEpDsBm3csFOTZyYo7wVPi7MsXDhWYlAUk/vrmUdrOzpZOwGU0mZreFKojgJggq/uUbNzJFvZ196ExyXlfUFMehZrzI3KVqFehpm7YEDhlLFScoDjJeAVNS6Wg76eojDay0YRec7Ls9fS8lf06vwT0hrXVQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 12 Jan 2022 11:28:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Macros with arguments need to be invoked via $(call ...); don't misguide
people looking up usage of such macros.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/scripts/Kbuild.include
+++ b/xen/scripts/Kbuild.include
@@ -43,15 +43,15 @@ define as-option-add-closure
endif
endef
-# $(if-success,<command>,<then>,<else>)
+# $(call if-success,<command>,<then>,<else>)
# Return <then> if <command> exits with 0, <else> otherwise.
if-success = $(shell { $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)")
-# $(success,<command>)
+# $(call success,<command>)
# Return y if <command> exits with 0, n otherwise
success = $(call if-success,$(1),y,n)
-# $(ld-option,<flag>)
+# $(call ld-option,<flag>)
# Return y if the linker supports <flag>, n otherwise
ld-option = $(call success,$(LD) -v $(1))
|
