Re: [xen-unstable-smoke bisection] complete build-amd64

[Jan Beulich <jbeulich@xxxxxxxx>]

On 21.01.2022 04:38, osstest service owner wrote:
> branch xen-unstable-smoke
> xenbranch xen-unstable-smoke
> job build-amd64
> testid xen-build
> 
> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> Tree: xen git://xenbits.xen.org/xen.git
> 
> *** Found and reproduced problem changeset ***
> 
>   Bug is in tree:  xen git://xenbits.xen.org/xen.git
>   Bug introduced:  6536688439dbca1d08fd6db5be29c39e3917fb2f
>   Bug not present: 88d3ff7ab15da277a85b39735797293fb541c718
>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167778/
> 
> 
>   commit 6536688439dbca1d08fd6db5be29c39e3917fb2f
>   Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>   Date:   Wed Jan 12 13:52:47 2022 +0000
>   
>       x86/msr: Split MSR_SPEC_CTRL handling
>       
>       In order to fix a VT-x bug, and support MSR_SPEC_CTRL on AMD, move
>       MSR_SPEC_CTRL handling into the new {pv,hvm}_{get,set}_reg() 
> infrastructure.
>       
>       Duplicate the msrs->spec_ctrl.raw accesses in the PV and VT-x paths for 
> now.
>       The SVM path is currently unreachable because of the CPUID policy.
>       
>       No functional change.
>       
>       Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>       Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Hmm, looks like you decided to drop the inline stubs, yet now in the
shim build we get

msr.c: In function 'guest_rdmsr':
msr.c:431:16: error: implicit declaration of function 'hvm_get_reg'; did you 
mean 'pv_get_reg'? [-Werror=implicit-function-declaration]
         *val = hvm_get_reg(v, msr);
                ^~~~~~~~~~~
                pv_get_reg
msr.c:431:16: error: nested extern declaration of 'hvm_get_reg' 
[-Werror=nested-externs]
msr.c: In function 'guest_wrmsr':
msr.c:675:9: error: implicit declaration of function 'hvm_set_reg'; did you 
mean 'pv_set_reg'? [-Werror=implicit-function-declaration]
         hvm_set_reg(v, msr, val);
         ^~~~~~~~~~~
         pv_set_reg
msr.c:675:9: error: nested extern declaration of 'hvm_set_reg' 
[-Werror=nested-externs]
cc1: all warnings being treated as errors

Jan