[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI architecture
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 27 Jan 2022 10:27:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uAJMKBzHmpJiyKX99hTGyy4QJF5IOpcj1B8d/meTB1o=; b=JBSBBEtaAb4N+qIV77youN/sKdpz+hWOI6+FY3jb1Em4TnDyODb+b8OPYUPtOSFcKps+ygXS+zPdMsCP9qtovVLRY8YT8KDdd2Q8Rn28BCe18Du64w8vLCcwIrupqpXNiSjWlAK95Q4zGuq65E5GVuoTSryAWJKQM6+PODAN7I0AYRDCJyUoz+CBwdVtVWxNmIJ1VylFivjyorBiSbK6/9pMDjxHvhG08YfVN3mfX2e0aAKHKFahDv3oZU0R89bnJxe0hpjTFKE4UnR9KmX5FEZNFnADHhH4TMYoicE8AQQ+CKkx/takBz+aco2tf64wUUmfUe35hmgFNllYWrsbyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUAzvDcp8MOJuQhlTmKToADnfl7w9bqfPfWppLZJvsmopxmjyiF5FLgVSZ8dfktWXNrzpNRk0hm5Jz6QLYOwj6NzkNVcdpg8rHHLbMrV/jeI2tsm8OB9/Q24vvWZU4OzNwz6Ipu1oc0YdXT74jJ/spCpMGqycWWeb6XZHqjMfMteLdYY5y5XH1IIRGgjx39Zvv98QZrQLeMT8gHCRtuiHkKs9EEIUSATsGtsO9iXV7QslMEum9Yknew7kLkzBI7dJfW2mFaT4JV5Z7u/j7YImlrcA+sf+USpK90BdYxh5AYcRxYpwI/I+/K0w1ZgEz1lzByuVVSxN8HVBAvfEqiUkg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Thu, 27 Jan 2022 09:28:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.01.2022 10:25, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年1月27日 17:17
>>
>> On 27.01.2022 10:09, Wei Chen wrote:
>>>> From: Jan Beulich <jbeulich@xxxxxxxx>
>>>> Sent: 2022年1月27日 17:00
>>>>
>>>> But you realize we already have such a stub file on x86?
>>>>
>>>
>>> Yes, we found the redefinition errors that are caused by x86 stub file
>>> and new macros in stub.h. We had tries to add:
>>> ifeq ($(XEN_BUILD_EFI),y)
>>> CFLAGS-y += -DXEN_BUILD_EFI
>>> XEN_CFLAGS += -DXEN_BUILD_EFI
>>> endif
>>> x86/Makefile to gate these new macros, but it seems that we may need
>>> to change EFI build logic for x86. It will cause more risks for me.
>>> So I want to introduce a similar stub.c in arch/arm.
>>
>> While that's perhaps fine, ideally common bits would be common. Iirc
>> already back at the time I was wondering why stub.c had to be x86-
>> only.
>
> Some dummy functions in stub.c can be shared by arm or other architectures.
> But some functions like efi_multiboot2 are architecture dependent.
Right - that's no different from the bulk of the non-stubbed EFI code.
I don't really mind you making an Arm-specific stub file if there's
not very much duplication, but it doesn't feel very good. In the end
it's up to the Arm maintainers anyway.
Jan
|
