[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/altp2m: p2m_altp2m_propagate_change() should honor present page order
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jan 2022 09:53:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUzAP9JVzF5H5p9YakG9eno+1QeuPEvTuoxESP2eKw8=; b=hlp7/3P7PU3Q6GqZzzVd48GE0R24WA05e2fvDLYmY6SB1aLQhtiY7s3zDAKgftjLOslw5kdrZ0i0PsTZbyIgyV8wrR+TKu0BtKHE3zEPimaPVBSOip7mHwSQ+Np1kHps0sL2wQhfK1d4M6Qc5hSpCUy/YYNk4UGgYI+zv3r/pjVje7Nil+upykrvgR2UuWib+QmiobEnPLxsr2HbeDB5omHzUW2pBhDAi8ODYnhm0ijquW9+YD6P7T+uk3hmm2AiaLTkQgH7gO4hA2R2uwhRdngNoFbYPJW8rBMWpFwei+QFARuEbw3sQjYkZukPaapEDdvDQ2bkBkSAe00xaFARoQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XVRqEtdq/xnxWvOOPWeiv5PXPqUvqiGQPhAyxgcwDlEYT6yTDW2kfzIrkI/PyL3ByJOHe/al2q41EwM0pmFv6/Od1vQAM6ePQgyXVlq7Gu1l2WG3LfJPWJz/1BUjzN/EuxjImNc+tvkqKkdkYBdUDiTr9G0KuB+ve7Him1W6mr49RBHjKEEHJxPo6SEp8JJlZopUXi5fjf+hMSjoUob1sKG1f39iBjPO9x6nXJ7cgW3ZqC3HWzGmQ/8epxhp0lgpxkvWF68jwNtQp0toO45C69xe5PJZB4pWHCNifdmn3NYMUtupl7k4p9Bwix67f2OJatVJTiiLN8K1FdOdfpdfLg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Mon, 31 Jan 2022 08:53:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.01.2022 17:49, Tamas K Lengyel wrote:
> On Thu, Jan 27, 2022 at 10:07 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> @@ -2549,15 +2546,16 @@ int p2m_altp2m_propagate_change(struct d
>>
>> for ( i = 0; i < MAX_ALTP2M; i++ )
>> {
>> + p2m_type_t t;
>> + p2m_access_t a;
>> +
>> if ( d->arch.altp2m_eptp[i] == mfn_x(INVALID_MFN) )
>> continue;
>>
>> p2m = d->arch.altp2m_p2m[i];
>> - m = get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0, NULL);
>>
>> /* Check for a dropped page that may impact this altp2m */
>> - if ( mfn_eq(mfn, INVALID_MFN) &&
>> - gfn_x(gfn) >= p2m->min_remapped_gfn &&
>> + if ( gfn_x(gfn) + (1UL << page_order) > p2m->min_remapped_gfn &&
>> gfn_x(gfn) <= p2m->max_remapped_gfn )
>
> Why are you dropping the mfn_eq(mfn, INVALID_MFN) check here?
Thanks for spotting - this is a mistake in the v3 rework.
Jan
|
