[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jan 2022 12:53:42 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cmFb5hq5X/1TPJJ152bim2bVrQUQ07lwNlLYeO5hMKI=; b=eAoSt/VbgzTPCLZWJOBR6DuFxFp7LxoHxUADrvKJXPbjdMtTjSBNiFeH8Q59q4D6H3paHu+/MRhlFny8FhrnwRg83yGTXWCJFh6CkmhvFWzgt9xV6Z7xpj3zLzBPqKQmcEiO0OSLpyZUnkK6YCSSCtRgYXWvq+f7+DVw93nLKcpvtT8R05MhuEibWSOrWoSYBPwntrJdTh6mWWjLCzt7Xd4d3ljSX+SfXEbdtK8SlMBWujeRoFr8o1X4uIkGywGK0/T0vzO+11SWoPCXSmvTbWYyuV4Buc622W1VoUtAG/ibTgq2rnhuSV9NNOZbuhbH3EtN7/RqubZS36i5smJPag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXgxfWaMNqrxXw56GiAos/IwAOF84x5yosXBDX6jZBHeFtDi2AUDZ06pfDykR26jaLXDmQz6iuM4zlMMD7BxnxoyXp4HgYxbj8bHHCgMvgXs1aE6tNt2U5/wAU8U0EhFxG/YsvU9XwNqsegW54t1IYc9PS8dkIL5JgV1RU1GhpzcXX/IHmMU54hdBXK5QmwTJ3GO6NCkdvCXhwKB/14hIGVPdynqlWLTGy43fkfp/39rU46OS2j62DxYZXMwHmWzqx33sTFNWPB2oGoqhjLXNWRDcW2rMsjiONlrqPfw4gjFELdUyRbN0tiV5hywiCohzTCUADTYOMCzQ+eqjI/Hlg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 31 Jan 2022 11:53:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.01.2022 17:01, Jane Malalane wrote:
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -343,6 +343,12 @@ static int vmx_init_vmcs_config(bool bsp)
> MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
> }
>
> + /* Check whether hardware supports accelerated xapic and x2apic. */
> + assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
> + assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode &&
> + cpu_has_vmx_apic_reg_virt &&
> + cpu_has_vmx_virtual_intr_delivery;
In patch 2 you modify this original related construct:
virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
cpu_has_vmx_virtual_intr_delivery) &&
cpu_has_vmx_virtualize_x2apic_mode );
As a result I don't think the expression you use above is correct.
Jan
|
