[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 2 Feb 2022 14:21:13 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MvCMUBlsWjf8kbdnJF6lsZiPWn0BJc9zVPZpXdap5yk=; b=WxqqBDDNGIMzjMSz/Uje3dfcxvvCwe53aq/cyQX2mYMknz/wfbgrErNgjXFbmWmggCsC+ix33Yd6nv+kP6COq+l7eCdYzXJO5pHdrxaHHog12+o0tRWMPdK99W2DwNlPrHfi5suTWNVncP6d/uldAZ63F0dya6Ql5C79jKHnXw/yr/sQ18ZX23tNc8JNOwFEK8tSXXQsu+xzixUr3NhtxsR+/kFh1OBVUphLuqTDOCoAOi1ZoHb7ps+7WkROtSfNA7/NMWrHV6dTflLawW8ImIbInP9A0NBWJfxfN1w9MEUCOEKJK82LZ9WQhQGCpZtN1rTa/eBj9LJD9wV5idPDLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6tE9MYgd/N1BvHK9dLh+/jESXyeAsfmg6/WsxXlXuT8OBqPEBNowYPGItOjZoLKmLmKEWJH6XjQPMduJ1fZA6saiIq+2nDx238innQliJ9vv3hCTZfBvRvNCsZtpEKQAOuapY/UC2e+ZXXh0NfOMZ98mL8e/5Y/kbGgcP21w8kklVQZScyHo1IJkGnDQzbHz7f692rlDBMcJ1xmR7crgSBL28vwO+qbw8zNTTJmwsUwDOWD4G1uEJl7xjTkCzvO0Nm9pciE9lKXvGECOKKMvXISAY54aqTLxiuny0NYJWBMh0C4Q7P2tB3ZlQrSJW8LPmj0YdwT44BCCVXv62jDLA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 02 Feb 2022 13:21:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.02.2022 13:13, Roger Pau Monné wrote:
> On Wed, Feb 02, 2022 at 10:42:22AM +0100, Jan Beulich wrote:
>> On 01.02.2022 13:45, Roger Pau Monne wrote:
>>> --- a/xen/include/xen/mm.h
>>> +++ b/xen/include/xen/mm.h
>>> @@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struct
>>> page_info *page,
>>> int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
>>> /* Returns the page type(s). */
>>> unsigned int page_get_ram_type(mfn_t mfn);
>>> +/* Check if a range falls into a hole in the memory map. */
>>> +bool is_memory_hole(paddr_t start, uint64_t size);
>>
>> While resolving to the same type, these now also want to be
>> "unsigned long".
>
> Doh, yes, sorry. Will convert them to mfn_t if we agree on that.
As said in reply to Julien - I don't mind the change, but in this
particular case I also don't view it as strictly necessary / useful.
Jan
|
