[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxl: don't allow IOMMU usage with PoD


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 3 Feb 2022 14:50:40 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=24HJAMn6dwns7ZrlAtR65gk3ceNBsb4qPm0v4UZ40f0=; b=kusBJYKW/18U7bD90QjBwucF24lizSyFZ25BHE8tw+02bIkq2JdBL5sFo2rxxHPLk708OHA2otmtm/XE62/EceXqnvKnAYUdC/1UuMlhLH3veN2DkOi+CsVz/Dy5P9seEEkRJ+MjDRHkABxtvF+wWztZpx56Zoug3gpMZJzaxlDdUPYSiT74C5ZKc8SlorHJOtd5E57Hh22OLjbjAulPf9wHnKsCLVa/5uSOwMejwGx9bo41W8J4VLPj8/ysdih/C9p4O+I+B7jRbLzDfQaESAzd3HRfrwCWlmB2M1mZ4XluSanyhPiIRCOllrSLA54Quh3f4D78bLU5l3j6V6ct5g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WYwEafNT7zZ5edQjBTHcc5JVQ0gdvPopmzeKSUX/sU7rMbCPkqNsaNwUzi494Z9toPXOmX1X90Wt2m1bclF4+drycUFC4TNLXqDBaJOSIk4dbX0NfM90KumjneED8y9+ZXMJErXtY1YcOH8lbfEtG9UIvySjB5qLIXJsmbFeJpG6gBxwbbvz4UugUNq/rFtIVr7ZZIo4ST3XHLqpfDZ6u8GpqGHj6WyIVSg9lHX16kd/Xf7/pCDQcNGbAjvX5bUGaTm86NPjVuDGIamVd6Mwyqn62FLpOKwGOLiSMJ48E8ztSd+bM78TfY/ZA2yxLGu1ujkHtFhyS9TZncN0RdHB1w==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 03 Feb 2022 13:50:58 +0000
  • Ironport-data: A9a23:clEjcq0/Xmu88UmXPvbD5SJ2kn2cJEfYwER7XKvMYLTBsI5bpzFTn 2dOCDqHaKrYZ2L1LtwjO43i8UNT78PTnIVnTgNppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Vh2OaEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhsoBOz OxRq6aMZ0QABfaRvuk2SCd4DHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4QIhWdp2Z4m8fD2O s8JLgZVfAn8XTJJYFYaDZEcksWziSyqG9FfgA3M/vdmi4TJ9yRz36LqK8H9YcGRSINemUPwj nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZCglee22gSAx0+TkagrL+yjUvWc81bA 1wZ/Gwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4oeE3AKgGnY+chACQed96ek7bicU9 kDcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocd7xorqp5 iFsdy2iAAYmV8rleMulG71lIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1O x+I5F0MtcQMZxNGiJObharrUKzGKoC7TbzYug38NIISMvCdiifblM2RWaJg9z+0yxV9+U3OE ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efAOBa9FOlUWHPTPrFRxP7V+239r ocAX/ZmPj0CCoUSlAGNr95KRb3LRFBmba3LRzt/Lb/ee1c2RT16Vpc8A9oJIuRYokicrc+Rl lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZz5EAlAvPtSi6rkxbZwyceV1/eBv16csH fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
  • Ironport-hdrordr: A9a23:m0nguqj0OsSaZh7Y2Hhbd+ktm3BQXzh13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M 323Ls6m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w 3+CNUZqFh5dL5iUUtMPpZxfSKJMB2/ffvtChPlHb21LtBPB5ryw6SHkondotvaPKA18A==
  • Ironport-sdr: R169npPNz6+bqMpH37TtUfVe26HslTAQ4nRe3FmxXcUMW1daKJ5uaOC8gM1Lz+Xg8fSQxX5CQm XfqfZ5ysXpWyFeZ7GZks80KWXj96K4l5K16aBN29mkC99F3Y4/Rm0LUf+K10vULASAFbuOmf/G E9XiB8rJapjjNNUA6Bryob0smWma4l4yof40il7PyH/v4haoUuFhCq7SJ7K05G5gxm8CiGn4Ku M5DOL012vL32Mb1LbFyseqox/c4vcamLUpcLuptNBrRumvH7JMXuT3eBqrmkgvhpI0eSHtp+y7 O9NstBOCiGgsZVEtjhTkiFXS
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Feb 03, 2022 at 12:55:56PM +0100, Jan Beulich wrote:
> On 03.02.2022 12:06, Roger Pau Monne wrote:
> > Prevent libxl from creating guests that attempts to use PoD together
> > with an IOMMU, even if no devices are actually assigned.
> > 
> > While the hypervisor could support using PoD together with an IOMMU as
> > long as no devices are assigned, such usage seems doubtful. There's no
> > guarantee the guest has ballooned down enough memory for PoD to no
> > longer be active, and thus a later assignment of a PCI device to such
> > domain could fail.
> 
> That's not a precise description of the constraint: The guest ballooning
> down enough only means entries == cache, but for device assignment we
> need entries == 0 (and a guarantee that no new entries can appear, but I
> think this is already the case once a guest was launched).

Would you be OK with:

"While the hypervisor could support using PoD together with an IOMMU as
long as no devices are assigned, such usage seems doubtful. There's no
guarantee the guest has PoD no longer be active, and thus a later
assignment of a PCI device to such domain could fail."

By "PoD no longer be active" meaning cache == entries == 0.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.