[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 4 Feb 2022 10:28:16 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gt4df4tSvvF/CDg5OmvKefIUNSyCVVQSGpX8Y+Tig94=; b=n1mB9eS9Y9LueLGixEk0auu22OnRykVbdNx7c5Hy0zFizCz538H/T7K0FDhozdJdK49LahnkD+2C5s9BprSyRNdA10CJK7HmmbkeNh6ovsTtzXO+vWOrZ5R2m6D0mMHZbEjj9sxeDfwzUDFshz/tBZkqbr7iu3ed9sSsH3+/m1qtLnnerOgNvSaXKjmSSSZ329JqSanSLJepfyNGD80JXFVns+COeWUp8GrjjS7cxoJSTtC2+nQDU+shgL6s5D9ealHTAMHAlckHnBhhYS86tmdeRnwX/O+OZpSmhVxPQPaOJzb4X3mB9Jzh2cuRI9xcWEbWzrydZ4eGMHWZp7GISQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g0B3UTgynD6bfrH+9ilAUJyEUm5AvAE6qVAsCS7/brcPraIjzIyPb3fnpncI/xjcE5z0M4cabh5DNv76jb7VNCfwW1otntm3kQ6nzwk9Wm1yAKifX+KAFZjbZRuDEP03Eq1m0GtlSBOrDWtuYB3qM1RZk3qCsw3ZN5gY0J1bRXOvkEhKF+65ZCU1iyxeC2lKPwKqv3MEdDqxlekuJZZQFLrI3oEvBhRXye8mmXhdcOcyAS5st/n7DD4aLfwtMfImXtczOzOKgsCeAkIAUvFl7oEiTPNcU5dI5fusj0LSdlyYMjimf9FYz7qsYdZFzrY+CYHjN7zvZ9qr7XvPjun7Bg==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Fri, 04 Feb 2022 09:28:38 +0000
  • Ironport-data: A9a23:Minqja8/jgEqHFrAGSqQDrUDZnmTJUtcMsCJ2f8bNWPcYEJGY0x3y jAcXmGOPKyCN2X1ftByPY6wpBgHuZOGzt5lTFFk/ik8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3tYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPha2 IUT66GJdj4mfYbtqfoBDyFBCDFXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2tg2Z4SQZ4yY eI9cQFlSDjOWycUP2pOArkHnuCFt0vGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc QpOoHNo9PVsshzwJjXgY/GmiFWU7kBCZuNvKuJ5wyC81LaI2x+CFkFRG1atd+canMMxQDUr0 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodt3xor6p5 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/JtALvW8jdRw2aa7onAMFh meJ4mu9A7cIZBOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ1mkgWmD2CLbimn0XP+efPPxa9FOZaWGZim8hktstoVi2Pr YYGXyZLoj0CONDDjt7/qt9OdA1acCRgWPgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5 HamXUFEjlH4gBX6xc+iMxiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
  • Ironport-hdrordr: A9a23:2YGIB6pX5/tatIy7f9LQZWAaV5oXeYIsimQD101hICG9Ffbo8/ xG/c5rsCMc5wxhO03I9ergBEDiex3hHPxOkO4s1N6ZNWGN1VdARLsSi7cKqAeQeREWmNQ86U 5ISdkGNDWuZmIQsS+B2maF+nwbsaG6GduT6dvj8w==
  • Ironport-sdr: PAhuP5CsnwTIDnGTQTeSxpuNSgEfDDF8w5nQac6yFIQOFAePuVR9MsorENGjePTzDnipnhUQKs m063YrXle5Se+ENFjhsSrtKH0NdLIb0bFq4wesVzaNEmuFIzt1m8PpLeYDuqtiVKYkQlR20/8i O0hwjU/rM2MutPx0OwCEJQBNNU0tRm960xvfaSv5ZveKOYqOT/BPfW8uBwYvfseRHcpEXrFBEz BrXxERUkKP7UNuNw4jm30hpdIa7WNU6cGoe5QBU9h+bnzY7LxH5Ae4mlsFeYTKtelQRwDVnoor xFx2tdGkT8WcV4jCfibXXWJs
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Feb 02, 2022 at 04:29:37PM +0100, Jan Beulich wrote:
> On 02.02.2022 16:14, Roger Pau Monné wrote:
> > On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
> >> Do away with the "pod_target_out_unlock" label. In particular by folding
> >> if()-s, the logic can be expressed with less code (and no goto-s) this
> >> way.
> >>
> >> Limit scope of "p2m", constifying it at the same time.
> > 
> > Is this stale? I cannot find any reference to a p2m variable in the
> > chunks below.
> 
> Indeed it is, leftover from rebasing over the introduction of
> p2m_pod_get_mem_target() in what is now patch 1. Dropped.

I'm happy with this change with the commit adjusted:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Not sure if you can commit this now regardless of patch 1?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.