[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 4 Feb 2022 14:46:27 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RyfF67Jj3oWm+xcD9BoIoW5ugD3+fW+zjhMlKkWfeaI=; b=JmTWbeCvYomD3ILGketi6iDsIj8K/Ojd+bZezH0Ncmb71xO+vBtgvq9cFyk42XBOiLkjLLw7ldf5792C+YpRZ6eXfcyC3P+YlTbzDlpy2l3C/NarmheIeLs/TqzSf/q6jyDWX5vueL4TFPC9GTAVPxmityvYWsf1qSRi6HVLS4as6Qj88LbgxqwRXFd2v0PAUz9J+wedr/GmfyI9Zs/ARniJdb80YmGdU9I5aDXCQFMs1KnzYWzP1xpCXOgVP/hc+DmIghqP+1oH5qdcu2yN/s2T++1jR5Iexh1q0EfxsQx0oApL7S+VtU4hSWbbWOUygddD8QEz1tKo93TjYtBk6A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RGA+2Ylo2wt1D+KQl00TGefAhmphPqX3sUUXSdrs2RerNjA+Gk5+3Sn6O0oN7fTK1s+2ZMQaACmX2I7vOUolB7BoQV8xtOvcXu5H457uZH920IC+Xvri77nEsLAb42JEnAfyhTt8z36D597oOulVXb2ipRk4H4vEYzfQ/aCA1QCtc723r+Nf4vugQcMCmU3maWNABtzHAFR2ES0UO9DF6te1f/w7bHpb/W4+Wed4ljyEq2q7hn55TxXDmz2fvdG+FiFa1waIi9aVUP1poEIA0W6m/dRYimq2JGLIawycEd4kl1YY4WHgbsJ/+J10uZL7BeauX5u9BCMFaXbVEyXLzg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 04 Feb 2022 13:46:41 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04.02.2022 14:34, Andrew Cooper wrote:
> On 04/02/2022 13:09, Jan Beulich wrote:
>> On 04.02.2022 13:12, Andrew Cooper wrote:
>>> On 04/02/2022 08:31, Jan Beulich wrote:
>>>> On 03.02.2022 19:10, Andrew Cooper wrote:
>>>>> It was Xen 4.14 where CPUID data was added to the migration stream, and 
>>>>> 4.13
>>>>> that we need to worry about with regards to compatibility.  Xen 4.12 isn't
>>>>> relevant.
>>>>>
>>>>> Expand and correct the commentary.
>>>>>
>>>>> Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore")
>>>> But doesn't this commit amend 685e922d6f30 ("tools/libxc: Rework
>>>> xc_cpuid_apply_policy() to use {get,set}_cpu_policy()"), which is
>>>> where DEF_MAX_* disappeared?
>>> No. All that happened in that change was that we switched to using
>>>
>>> cpuid.h:89:#define CPUID_GUEST_NR_EXTD_AMD
>>>
>>> instead, which remained the same size until Xen 4.15 when e9b4fe26364
>>> bumped it.
>> Oh, right. I did try to look for a replacement, but managed to miss
>> this. But then, as much as 4.12 isn't relevant, isn't it the case
>> that the fact that CPUID data was added to the stream in 4.14 isn't
>> relevant here either, and it's instead the bumping in 4.15 which is?
> 
> The fact that the bump happened is relevant, by virtue of the fact there
> logic added to cope.  The fact it was in 4.15 is not relevant - this
> isn't a list of every ABI-relevant change.
> 
> CPUID data being added to the stream is critically important, because
> that's the point after which we never enter this compatibility path.

If the bump happened before CPUID data was added to the stream, logic to
cope with migrating-in guests would have been required too, wouldn't it.

But anyway, just to be done with this:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.