[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the VGA information
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Feb 2022 09:57:55 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ZYDkpSFsIdm1YfqalckYcs9mzKa546JvAv4YG5D2G4=; b=LFP3zttaktWzBwAeDOFwHk4ln1Od0m3FIZ1HYrZZJK+P9r7mQG2vmXzCwoDa9s6ojxGGNf/JlMhLU/VcGSFGJcSBnuEG7HYtvvX4fHKuWQvG0nVAS+S0sijlzyL3YQyNJGt4Xu3Djkh0ED1tHrQBIKxrgovCgwoniPROAsy6Y9LQj7PLYM/MeH6duhCJ7OrXRq/8Pw0q3REoTkT7uY4Ry4gzZLNtjDIXXdMedS8Hh/PMinc6ElP8FBHXZzq6ECJP4tVBcUEEtJV4APeoPfpOe61TD0yC5GK8U81wfHwr8qwhhqeTTe+KHkEefVdQX9mxKwnqD0fMHpeHN+RPGKYwDA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aJzIWNqbOHCHQ/PEPwqC3BxxTuG3/o0D4l0QiqoPWpw26zVGTy9LLv7ItZOFjIlKJLqSIaC7GUNeFiR92nMle68ozTP7mGq1CbPhKjNgHZVRoa6ERNEXuZddCYIZ3exmvHPrAX2EUIvwtTHiA7LAOGpsIlwqjVCuG/IOiYS9pckZ62ktSn6uhtPz7+2OSKK2jI5tpH7qyh2wPjWLtxxk8B8vDEiBkcZK0b8NV5P/aXhdY8AiisnYsgcL+Ac6uvKwQI+r1cT8s7drOUprnFJWLM/KsILBOxdUqAgG63YcD/24UMUNJ+yLm6n1plVGRO2NpzJ3LU8khC+bp/Tw7RI7Vw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: ehem+xen@xxxxxxx, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 07 Feb 2022 08:58:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.02.2022 20:28, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> When using EFI, the VGA information is fetched using the EFI
> boot services. However, Xen will have exited the boot services.
> Therefore, we need to find a different way to pass the information
> to dom0.
>
> For PV dom0, they are part of the start_info. But this is not
> something that exists on Arm. So the best way would to be to
> use a hypercall.
>
> For now the structure layout is based on dom0_vga_console_info
> for convenience. I am open on another proposal.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Cc-ing Roger as this may want using for PVH Dom0 also on x86; my
first attempt to propagate this information was rejected.
> --- a/xen/include/public/platform.h
> +++ b/xen/include/public/platform.h
> @@ -244,6 +244,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
> #define XEN_FW_EFI_PCI_ROM 5
> #define XEN_FW_EFI_APPLE_PROPERTIES 6
> #define XEN_FW_KBD_SHIFT_FLAGS 5
> +#define XEN_FW_VGA_INFO 6
Perhaps s/VGA/VIDEO/, despite ...
> struct xenpf_firmware_info {
> /* IN variables. */
> uint32_t type;
> @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
>
> /* Int16, Fn02: Get keyboard shift flags. */
> uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
> + struct dom0_vga_console_info vga;
... the structure name including "vga" (but if the #define is adjusted,
the field name would want to become "video" as well).
Jan
|