[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/16] x86/P2M: drop a few CONFIG_HVM
- To: George Dunlap <dunlapg@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Feb 2022 10:51:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pwgq335aOJOtqXr46wEMq33uLC4uGbizI9qqa8QslsU=; b=QRfnpGj6mH9FZGYpU6fOoKHLuF0Pjz1jX6tzsHzlb55DNtusdbvBm/Ouio8ObnefLZ2tVbXr+RYwJK7+KFGKQdaIBVD2ccpQqGn0VXgtEeiDFfC9i+PM0rXtTNztKDOQWJSbC87x0LCMNPsCbdQGLDSv5fjAtWey1K4PJai7/b5s7U/DAMAXeq7xKHAmA3y3EOfEXa8DHLhfvRwr6pR3i/tIpqq0RLuq2aetmXolIRgSt272aVdmBTdbua3XdXdumMTKQpzJOkCzNRTNnzqNUPR8K2cbXdcc/OItufX/f3UL62oonh+pCmBYglbIPJRD77iyCCDfHYRKfomlS+JhjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGuj1CgOaTHaOba19z8DpKUNXI76cr0SHK8fbMesAio1QaZ5OR7nHewZUPvD47fM7Etsrnj9fZ/I6L+VyDvbGk+qMZGlwq4BzM4uKX1Kp6d9rm83v2uz/Ot6o/p/qv5Hu/HHTbVDB0TmFh3jgjtO/bUaapgX0INJS0yLHcWvCJ7ef/M+GuhpOSPKYGgf0nM+m3fLE8TNYFnNsNfjnra/PzosGl95gPmzQYHcgj13Fv7Nn7KTlZDWXQfNbBLGT5cej9GtmSSoIB8b/5W9uNKzqAWSW4FWDRCpanaYbz1f4lLb9NgNEO9i+ZM3mJn0TsKF4OpHBFGYeC43aq0zAXaNJQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Mon, 07 Feb 2022 09:51:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.02.2022 23:13, George Dunlap wrote:
> On Mon, Jul 5, 2021 at 5:06 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
>> This is to make it easier to see which parts of p2m.c still aren't HVM-
>> specific: In one case the conditionals sat in an already guarded region,
>> while in the other case P2M_AUDIT implies HVM.
>>
>
> I think this would be much more easy to understand what's going on if it
> was more like this:
>
> ---
> x86/p2m: P2M_AUDIT implies CONFIG_HVM
>
> Remove one #endif / #ifdef CONFIG_HVM pair to make all the audit code
> CONFIG_HVM only. This is to make it easier to see which parts of p2m.c
> still aren't HVM-specific.
>
> While here, remove a redundant set of nested #ifdef CONFIG_HVM.
> ---
>
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
Thanks. Unless you tell me otherwise I'll assume the changed title and
description are merely a suggestion, not a requirement for your R-b to
apply. I continue to like my variant better; in particular I'd like to
not mention P2M_AUDIT in the title and this way avoid "While here, ..."
or alike.
Jan
|
