[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm


  • To: Julien Grall <julien@xxxxxxx>
  • From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
  • Date: Mon, 7 Feb 2022 20:04:19 +0000
  • Accept-language: en-US, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3q+4tKJYOMjBfbsHP4XIsGbDN7rsMa8a8W0Nzt5979g=; b=ZNVbUKh6JTs9UXTlNNuEyFfhSuoA+xTrfr0lZjFhqs8rIsa3Y9qtA/FK5CyRcLQj3IDryH/uzWjClO4lyala6nVy7sIO5DywAP9BD7xPardFzaXH6EdSX6nt1ecr9rddFLdPsGhlBfPX/wlZO+MIs7Be/mCU0DYKRi+VzsKDwRPj9c49AToSRjL1DgNeHrGBLPlMs4mQyloh89kQ164MbAFKnMGS9InZd8Wkj/6SfCqYxRyfpZMiHMi5lQcyGZ7EX1AfFkXiMeuKCxdsYP8BW8Pn9fwqUfTnVk577XQycqo69DyE/lH+ma+CfXlUMOSISBySqWgoDLMExy4DPm+lvg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEke78kK7gJbaU9FwrFKAJzdBOYxt5Z0utl5Wu3y6V0ayuNQLqev69OMxY607XGdZ6n+YT6NpneXTwa0XreMakItqmYKE+pYDr9eY7Uxx7bXMvVEY5zePeZi++gG7HU2KDzxqQYL0580WAGJeCmATp9uwfBKTRQ1/miYGktmG3v7WkhXhHH9Uk4x4SwT1Xa26nE9qkbPpoR2xwqa+dAOVEul2tMDPOl6B0Z3MFheD0bwTzsRHQnqAZ6PLvehOzjiyT7ere2MDB1mr7vs6ztkIiYWGtY3Z3f0IFzJAAYoqjKZ9cacZtZzqzvXbqoAzqbXLh8wsL1JrQ18zDGxS2cRVQ==
  • Cc: Oleksandr <olekstysh@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 08 Feb 2022 05:06:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYAomKM/4d8JNsdEqc8nNA4dib2KxWDBOAgAAkKACAMl6jAIAABJuAgAAAX4CAACLbAA==
  • Thread-topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm

On 07.02.22 19:59, Julien Grall wrote:

Hi Julien


>
>
> On 07/02/2022 17:58, Oleksandr Tyshchenko wrote:
>>
>> On 07.02.22 19:41, Julien Grall wrote:
>>> On 06/01/2022 16:30, Oleksandr wrote:
>>>
>>> So I agree with Jan that the name should be adjusted if it stays where
>>> it is.
>>>
>>> That said, I would actually prefer the adjustment in
>>> alloc_heap_pages(). It is one less assignment per page and I don't
>>> expect any issue with setting the bits to INVALID_GFN everywhere in
>>> the future on Arm.
>>
>>
>> Sorry I lost the context. To clarify, are you speaking about what I
>> proposed at [1]?
>
> That's correct.


Thank you for the clarification.


>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.