[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max conflict
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Wed, 9 Feb 2022 10:40:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=awSpnk9KzfJE1f7cDS5tVTLb/jHKmp11yzJIZm63+E8=; b=FxuUsRO394j7g4pYMu0jsjt+ENwYMYvpQAg0fRmMkzvdJgqWmMJAcK1YVRGko+06RmWizsRkpRiPflzhjuTnjDGcyLy0wMO1OmQjfhpz/rQXqoBF1n4jlbuaxD+1UKHF3WY2TcdFO64MrY3/+g3XjMo/vK0vHT9yscN08HaOUPrn8msXEfunJUULT+CbGF8e03MwQG2TMKJzwCLYYbGXgihkTCDlKjAI4DgWQ6acxvygwPECI3qj5yxTk487xi/1kc+1VT/yIexCBD8IEGFZ5uaJdfT6/nkcw0vkyMvsyyu0BCS9jRZDNr2waXb9/AHMYdNsyj+iVkzLLVqmgW+VDw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sq4KV6WYGRp47LC2vH2LezrP/DU/+4A21V7NV+mJw9+nzZw23aNM0/M0icckO17WHG3v9plYa1bWxLSF+p7AJmMAQaHHaw2c9xxRmLqRkjdKjb76m7aK6kbUN1Ie5CBGNSXH5qefeXAtvfFIekER8sYgOP+eJOfiXh8NVvd4tS2jy9oOlXS/jYSyFSk1WlT2FjjjEelIhKngwSeJtYm50njXvsE0MQPUKPLWUkt1cm1ZzOIVkSrkApV90ZuK2r/uytveK/4qV5ZMtiKAaVlRJHNf+IZ75nDKk4XmhltqHaucAbszVaIdZyyi2kIyH+B0c/phZtb6qf90tnEZVKQkQA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 09 Feb 2022 10:40:24 +0000
- Ironport-data: A9a23:VdGiNqhemN/6sGThMaVK0V1UX161ghcKZh0ujC45NGQN5FlHY01je htvDz2PO6vbZDD8eIxxO9izpkkGvJHWzoA1TVFupHhnQiwb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw0IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1LqZyWTC0bBJbK2/VaYUNgFzF/N5BJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHJNYUS/FRpyTjdBPAraZvCX7/L9ZlT2zJYasVmQ62OP pVHOWEHgBLoX0RPfX0dF7UEgcChp2n4LCdgpEuxjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0z7CBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJWD+0c7Su/8JHSoBfeNDI8Si5AYuEp4ZpeqSMR6 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HxgbQ4xawZRGp8crVnl CJZ8yR5xLpRZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBsybptYKGa5O RK7VeZtCHl7ZibCgUhfOd3ZNijX5fK4SYSNug78MrKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIZ9bawHmRr5is8u5TPD9r o832z2ikE4EDoUTo0D/rOYuELz9BSJjWsmt9pcHL7Xrz8gPMDhJNsI9CIgJIuRNt69Uiv3J7 je6XEpZw0D4nnrJNUOBbXULVV8ldc8XQasTMXN+MFC29WIkZIrzvq4Te4FuJess9fB5zO4yR P4AIp3SDvNKQzXB2jIccZii89AyKEX13VqDb3i/fTwyX598XAiVqNXqSRTiqXsVBS2tuMpg/ 7D5jlHHQYAOThhJBdrNbK791Eu4uHUQwbogX0bBLtRJVl/r9Yxmd374gvMtepleIhTf3DqKk Q2RBE5A9+XKpoY09vjPhLyF8Nj1Q7cvQBICEjCCv7isNCTc8m6y+qN6Ub6FLWLHSWf52KS+f uEJnfvyB+IKwQRRuI1mHrc1ka9nv4nzp6VXxxhPFWnQawj5EatpJ3SL0JUdtqBJwbMF6wK6V ljWp4tfMLSNfsjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTc2jZAKLZVMZ8+x bZzscEb3AWzlx42P4vUlStT7WmNciQNXqhPWkv222M3Zt7HEm1/XKE=
- Ironport-hdrordr: A9a23:hv5DpKEzK4uWm185pLqFR5HXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdsZJkh8erwXJVp2RvnhNBICPoqTMiftW7dySqVxeBZnMTfKljbehEWmdQtrZ uIH5IOauEYSGIK8PoSgzPIU+rIouP3i5xA7N22pxwGIGEaCJ2IrT0JcDpzencGHjWubqBJc6 Z0k/A33gZIDk5nCPhTaEN1OtTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNFNyMIv/MpTvKe0Tt8gDg06t M640uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pVVFZ9l/1WwKpuKuZKIMs60vFSLM B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpV+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOBl7fnpLEuoO26cp0By5U/3J zHTVNDrGY3P1njDMWftac7uywlgF/NKwgF5vsulaSRi4eMM4YDaxfzO2zGu/HQ1skiPg==
- Ironport-sdr: fkVgD6dN7PfKRx9cNiNxtFaz/vtPZJm0bPfE00Axrx0T+2YcPh3Nh/WQTU6jhS+VIXfWguAGmL lCC85XgCpsmgd4fDTCGNeg0fZdmqMc/km/FZw73wbVD840+kRKeo3qO8SBLWlJ8sc7G708BLIY +TVdYmIau1LhMVEdmpAVFFIimTOu+bVLGHL7gFDVWR/eZE6kpwXdPmkmf6QR/SMhNB9LAKt259 DscpE/P4lGYFEFHyj89piceluNEpRqVSqcwws9+xyAdSwCogevkPctxaseJ7fWnuyPYYKc1QlC pilGVrV7YVLk3HYJzFZM1rhl
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYHaBVLLQoAjzhjUW/NIePQEslT6yLB48A
- Thread-topic: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max conflict
On 09/02/2022 10:31, Jane Malalane wrote:
> This is not a bug. The xen cmdline can request both a NUMA restriction
> and a vcpu count restriction for Dom0. The node restriction wil always
> be respected which might mean either using dom0_max_vcpus <
> opt_dom0_max_vcpus_max or using more vCPUs than pCPUs on a node. In
> the case where dom0_max_vcpus gets capped at the maximum number of
> pCPUs for the number of nodes chosen, it can be useful particularly
> for debugging to print a message in the serial log.
>
> Suggested-by: Edwin Torok <edvin.torok@xxxxxxxxxx>
> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
> ---
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
> xen/arch/x86/dom0_build.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
> index fe24e11b37..e57cc80ef0 100644
> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -240,6 +240,11 @@ unsigned int __init dom0_max_vcpus(void)
> if ( max_vcpus > limit )
> max_vcpus = limit;
>
> + if ( max_vcpus < opt_dom0_max_vcpus_max && max_vcpus >
> opt_dom0_max_vcpus_min )
> + printk(XENLOG_INFO "Dom0 using %d vCPUs conflicts with request to
> use"
> + " %d node(s), using up to %d vCPUs\n", opt_dom0_max_vcpus_max,
> + dom0_nr_pxms, max_vcpus);
> +
> return max_vcpus;
> }
>
Here I was debating whether to use a printk or a dprintk, as although
this would be useful for debugging, it gives general info on dom0 vCPU
topology, as does for e.g. 'Dom0 has maximimum ... vCPUS'. However, I
defer to the maintainers, as I'm still getting acquainted with Xen (I
also understand this patch is of minor importance).
Thanks,
Jane.
|