[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties


  • To: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Wed, 9 Feb 2022 13:47:44 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjtRBZchUgkI311NrWgALTqmBaiGDVLnajzaK/LJct4=; b=GoSD/OkR5mpB/wAGGx9FRhp1rS1lezk2Nu1F/6WG5HHVZ43mP2+j9sXI/ty+JoCLTy40rrn1NqACNmS6AWqtZDbcPNwXIn9sDSkz+W/lkFf7o1nwjXXKBOwplDupBGywmMG+aIsJa4GUuzQQnq1tcb2QjmDtkWHW/OFwXbRH1A6CFi56zgh4lvaru5lGGZK2RhtaALVbgZ+YW1fcMVo9Mzxjx3ZRPwbqmeAEP5xU2zryDWtMRCYjAL8DtBdmFkfA8N6Fikj/v486ZqAEdwTc3q3w0rnta1tVIf70sRT5X8ZAny4bb3e3hPWzGaKAiXz3GFZBGMjASNAynueN19hs5g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hqSKa9QTQm9xOEL7YyOhXX8pDPAF3PL7msdaUlxev9XzY/AoMi9DojhqdhdACx66FkgOcSTajos6+cvYYPVahu6bviMHi0XaLv83eCvCQ5r2Sp9BUTXAU/o1zbBgqRUOAc2Ix4HSa0ZySTQtgdBrflLYEKf75T17uQxPJJUiD/a1QI3qdTsuzfX3mRY2HwSPEEcOtEUlGbzxiuZjz7fB2tgddhSBvjczUdHc+HucnO2XQKhQhlLz/gv/LFcjmOKl5zzc3PbuM75bsOxxkrqoz2+VqDZ7ie9ZpNYAokcDznYKfoj4q5yczBWkGKurOyKsV243EHV2ZgFayiZZlNBBbA==
  • Cc: Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 09 Feb 2022 13:48:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYHbudSLxWMD9F30i+VGpqKP0vfg==
  • Thread-topic: [RFC v2 2/8] libs: libxenhypfs - handle blob properties

Hi, Oleksii!

On 08.02.22 20:00, Oleksii Moisieiev wrote:
> libxenhypfs will return blob properties as is. This output can be used
> to retrieve information from the hypfs. Caller is responsible for
> parsing property value.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
> ---
>   tools/libs/hypfs/core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c
> index 52b30db8d7..d09bba7d8c 100644
> --- a/tools/libs/hypfs/core.c
> +++ b/tools/libs/hypfs/core.c
> @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char 
> *path)
>           errno = EISDIR;
>           break;
>       case xenhypfs_type_blob:
> -        errno = EDOM;
> -        break;
This will need a /* fallthrough */ I guess
>       case xenhypfs_type_string:
>           ret_buf = buf;
>           buf = NULL;
Thank you,
Oleksandr

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.