[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 10 Feb 2022 10:37:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZtpCU4yWwOywKrjRHV4KNx2PomzcJILfNog390sO84I=; b=P6V3wNSF6Br7UgTz8ya1et+TvaQCm5GcmUmQMCLEPF5RSrHs004unLrifNe0wYA1wLGglZBVkySkLIn9iGaeYkMFmTec8efwevV9A/D9GekGrLeIZxJHrYyj3oieBRvjIz42AQ9nnkkCwtBd3N0OqRfZwCt5XAoX2PFll8X01wtjfjfQfYf1CYGQY9KraDyzqPhkCVX0pg3DuyDfIxyhsQPkFkhp8y2If4w+V4ZWPob22N5lN35O358sxInWrZ+IL5KWeEATJZuE3GFdQoJcJc3G4ciMCQuxwBwgcS4fzEAFsm6LVP76qhHTpPrWBXOdwcNgFBlk5ze9Mm4qqAeEIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5o1kfBUyv3Lmhvfr0dS0hgNSPU0PFI188nmbjDFB3T+TzRxiXzpSmJFy5HHLt07sfew1gFBtO6NE7/tLnZz3pBLQG8W93qq24ML/vbPJSer55X8MHquBNS4gXkonQxqcv0O/kASlUp/Ql5qxv5TH9QU11vTXtL8DVMmpg6rHfR/QcKsvf8HZabDMnkXsHS73mr+b6fAXr7Hdb3ypW7pvZuhCNv+ieVpvY5X3+qaoavp9qPVlf2vbfYdh/a2Ya1CAxFPldgj6ApDnnkuge5o1iXgqnVzvdgLN5yK0zL7QKk4SN1S9LzxCGnyFBOWSryuJdWS0jIdndoXL1t9Kwah3g==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 10 Feb 2022 09:37:37 +0000
- Ironport-data: A9a23:1iEftqIZhHLMtsJwFE+RaZIlxSXFcZb7ZxGr2PjKsXjdYENS3zBVn GodCGqPM/uPajb3fo1wbI/n9xwFv8XWz9NkTAdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6w7Zg6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Mz9df6 9tcr6afUAgObqGSg8AcCTtXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uu4YCjGZt3aiiG97nb sEZYjdeMy/iQDlXakoWT4oMvLu30yyXnzpw9wvO+PtfD3Lo5BdqzLHnPd7Re9qLbcZYhECVo iTB5WuRKhMHMN2SzxKV/3TqgfXA9QvFX4YVGKy95+RdqlSZzWwOCzUbTVK+5/K+jyaWV9tBJ mQO9yEprKx081akJvHiWzWorXjCuQQTM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht9HjCCFrsbaVYWmA7brSpjS3UQAXInUFfjQsVhYe7p/op4Rbs/7UZo89Sujv1ISzQGyuh WDRxMQju1kNpctb0IuY80HduR21qb+ZQlAuwgSNfG3wu2uVe7WZT4Cv7FHa69NJI4CYUkSNs RA4piSO0AwdJcrTzXLQGY3hCJnsvq/Ya2OE3TaDCrF8r2zFxpK1QWxHDNiSzm9NO91MRzLma VS7Veh5tM4KZyvCgUOajuuM5yUWIUrISIyNuhP8NIMmjn1NmOmvp3gGiam4hT6FraTUuftjU ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6nk0j8i+LGPy7KGN/p1WdiiMhitctoRy2Pr b5i2zaikU0DAIUSnAGLmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mtscl3het/0NzI/gp yjlMmcBkQaXrSCXeG2iNyE4AJuyDMkXkJ7OFXF1Vbpe8yN4OtjHAWZ2X8ZfQITLA8Q9kaAqH 6NYJ61twJ1nE1z6xtjUVrGkxKRKfxW3nwOeeS2jZTk0ZZl7QALVvNTje2PSGOMmV0JbbOMy/ O+t0B31W50GS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbKh RyLBRo4pPXWp9Nn+tf+mq3Z/ZyiFPFzHxQGEjCDv6q2LyTT4kGq3ZREDLSTZTnYWW6toPeia OxZwuvSKvoCmFoW4YNwH6wylfA15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7A xvd9MNbNLOFPNLePGQQfAd1PP6e0fw0myXJ6ahnKkvN+yIqrqGMVl9fPkfQhXUFfqd1Ko4s3 cwopNUSt16kkhMvP9uL0nJU+mCLIiBSWqkrrMhHUoriiw5twVBee53MTCTx5cjXOdlLN0ArJ B6ShbbD2OsAlhaTLSJrGCifx/dZiLQPpAtOnQ0LKFm+k9bYguM6gU9K+jMtQwUJlhhK3oqf4 ISw25GZ8UlWwwpVuQ==
- Ironport-hdrordr: A9a23:e8lpsqlPJ+HGMwzPhG6EXaXUvXzpDfO0imdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH Pz3Lsim9L2Ek5nEfhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN gsfJ4Y0I2mdfVmHp6VMt1xNfdfOla9MS4kD1jiU2gPNJt3ck4l+KSHqInc2omRCek1Jd0J6d P8bG8=
- Ironport-sdr: YTp7Djafs6VAQeyqOo0EYxeN6NHtVMMDPMMnOTMKELJyQozdM9gmczyF3boSFQOaNb3RAl14Wv nsfhSKN67L0hpmYM8wVNmOOSA/PG6vOfT44iH/CnYj+HaWD7H36sGO3lz3N59rbuYuP65RAjBM awyAWMA3lTkQirs3Y0Z3p+qYDxqv6WvwdV9dCpNllxCWep+tE8Umz7zBHH0aXTiQ4E7TedIT8B JV1sKjp8gUhYqUwGmcVI33r22KZn2720nhUuD67eZD/hJGDcZpQZppgPT4BB0RPbnWbHpEWYm2 cNuDP1AYtPxl1kLEkNVZjt9W
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 09, 2022 at 10:57:28AM +0000, Jane Malalane wrote:
> On 08/02/2022 16:17, Roger Pau Monné wrote:
> > On Mon, Feb 07, 2022 at 06:21:01PM +0000, Jane Malalane wrote:
> >> diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
> >> index 485bd66971..33694acc99 100644
> >> --- a/xen/arch/x86/traps.c
> >> +++ b/xen/arch/x86/traps.c
> >> @@ -1115,7 +1115,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v,
> >> uint32_t leaf,
> >> if ( !is_hvm_domain(d) || subleaf != 0 )
> >> break;
> >>
> >> - if ( cpu_has_vmx_apic_reg_virt )
> >> + if ( cpu_has_vmx_apic_reg_virt &&
> >
> > You can drop the cpu_has_vmx_apic_reg_virt check here, if
> > cpu_has_vmx_apic_reg_virt is false assisted_xapic won't be set to true.
> Oh, but assisted_xapic_available is only set to depend on
> cpu_has_vmx_virtualize_apic_accesses, unless I should correct this, but
> I might be missing something...
No, you are right. We only report hw virtualized xAPIC to guests if
both apic_reg_virt and virtualize_apic_accesses are available.
Thanks, Roger.
|
