[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/13] vpci/header: reset the command register when adding devices
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 10 Feb 2022 14:36:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+tznKeogrT57KmWNOatTCYgVS8pizllRRCBa+7DxEI=; b=cNe0gmuqt341w3AymaJpU6gbA9A0pCQ/jqlSpmUeGTMA4BnK6V2o83veXryDzl/voFW+vG5eUPz/JpwAQNtnPCV44ajk2GNlg0fRCCuKx9LbF1wPHLX1VQoup9wraLUyqYQDcpj/UMG4DpLB5sr3JgLzC8RUbkpWznmV/EOG0E+8+LF+OsGA+fl3Db5cTEjN0ugVmIZMfFSM3VvXKdvGLHuWIu/C5w6dwbU/mKtZQvf4tngzNHyrOmysPWrTArqFRuBou7Ec6kz9TQIpCAZM1XSoXsQt5zdfgpbZmPi4AktM/iTuQmUInze9mFuYn2jwlI30fwQz3tLrVIMyExOsjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHXCKcXJp4JR1MhHPd9U5mUH9St8MCv7tWm4CaGfSNpmqmGwL2oG8BmCWK3giCFsGEQmGhoBoyQSQLiK7VF9EyAFnvu+duaWi9gnhPLmxO6sNaO4BQe2e6SDd3j5qUU0hRZI4NqWcp2HKNqNLrZZp9XVjLzHA88dWI1v6h9HHuFkCFRAG8M/YKA3pHfPHhgipiD97VJJIliPEuQFZB2PPkGobcF8OGrQLtppY1/U/BkDP4LHZm9OC3w/WPYw+KuyQf6WH4LbhxSrOsve0V3Qv6UPaJrdAvigQNiW7AkCVvsh4mFu1SyqxdZ48zjjjRb+dnF+a22+6YkLNTF+RekaNg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Feb 2022 13:36:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.02.2022 13:54, Oleksandr Andrushchenko wrote:
> On 07.02.22 16:31, Jan Beulich wrote:
>> On 07.02.2022 15:17, Oleksandr Andrushchenko wrote:
>> But: What's still missing here then is the separation of guest and host
>> views. When we set INTx behind the guest's back, it shouldn't observe the
>> bit set. Or is this meant to be another (big) TODO?
> Why not? This seems to be when a guest tries to both enable MSI/MSI-X
> and INTx which is a wrong combination. Let's pretend to be a really
> smart PCI device which partially rejects such PCI_COMMAND write,
> so guest still sees the register consistent wrt INTx bit. Namely it remains
> set.
I'm afraid this wouldn't be "smart", but "buggy". I'm not aware of
the spec leaving room for such behavior. And our emulation should
give the guest a spec-compliant view of the device.
Jan
|
