[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read on family 0xf


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 10 Feb 2022 15:56:12 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j5zMM3qKdb6oVy6iS2IeBm7vTPi70YImKG2OphmjMjY=; b=nCujtQU5viKNhfguBQQYW87CQHSO150Qk8NkY26zLEm1fny41yDBMJOFcoU3YsjD4/ma6jo72JV1cPVQ+mJTMt3BB0QwGJsnijhNssKK8RVVYJQ1UXfgbiqQgcHQdVDIxeucNjBXkz/lc3wFdqbxuLtdc9VhCW436RUumkXx0KkU/isGTwHXVu4ZiOut46+CW3jt0e/EgzfPlMu2+MPHQ6IDxbwL1/xJ8fIuxs+PDTBv3gqhivZD2SvudA7ebzbLAseQN24rrzhG/3be/FSAfK1MSNR/NjuZ/NdvN6ySbRzRb7aTKW9YI2gwkMwupFfMZnryGdD9Fdzh+Ko8owzaHQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOL2RxalxbJXiqJO7LoesobC6ldSk3kT9B1nHUf2BB23g+/DpFtvbELlTB3bFHzv4cTX5lyN61Jmy+GHwyLS8ATpeL4qbtLRwWQn38cICDi42wxdWckjCTiSSFN94POmkiS2vRcGr0gSxmme3H3y5fy82Xu+d3WIecyVzHNOtEpd+njef19U2NS+fg2dLu7kjU+scjrRo65gv1diZCnm3E4rhtwVXfzwds5K2uuO46a+a8yEV/Ggo+TQAB3zB6HYAmXzZ60noqc1OZSA9AIbS1v101RXiRl4CTR19jdU1ELgSxn6Vyn6CyTpdwLHrdhw1IsE9vA6UIXvC+RH206iKQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 10 Feb 2022 14:56:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This avoids an unnecessary (and always somewhat scary) log message for
the recovered from #GP(0).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Perhaps even use "== 6" in the family check?

--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -453,7 +453,8 @@ static bool __init check_smt_enabled(voi
      * At the time of writing, it is almost completely undocumented, so isn't
      * virtualised reliably.
      */
-    if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && !cpu_has_hypervisor &&
+    if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
+         boot_cpu_data.x86 != 0xf && !cpu_has_hypervisor &&
          !rdmsr_safe(MSR_INTEL_CORE_THREAD_COUNT, val) )
         return (MASK_EXTR(val, MSR_CTC_CORE_MASK) !=
                 MASK_EXTR(val, MSR_CTC_THREAD_MASK));




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.