[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask
- To: Bjorn Helgaas <helgaas@xxxxxxxxxx>
- From: Jason Gunthorpe <jgg@xxxxxxxxxx>
- Date: Thu, 10 Feb 2022 20:41:47 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4geiNE5wNKEzx7ODRCekobfzQJ2m4y0X8LjNiizgO3o=; b=X4ksOC1frQYNuqRvM/7/GG+8BxXHuR6FNre+5Ufpzi/UcjD+Bj56SEllB7bEIxhyQT5HOYUvdyzAsFB99AAUTL9vu21PWbB6RMn/s/5DBc6+vstv9TaKyhkvbsxPYvi8bC5KwqIqHczbUhX98qzs+pKiPHVmj/X0usQgtlgsQAMqteQPeRk+EKaqiRCm7YcdC4Icq4pZSH0ekriREZNjHfkC6Os7THhy+GFC8/evD4knfiqxUUGjMwFA8BxTyLigQfKRLUbHgjwD3sDaoFUxGcHC9nuKSzTsXkeuoO4t3ntn7RofR+xHRJPJ8ZjeP6L91vd68PC+IWkooUCIkk0/cQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmkwmLyXVipfiQ2fdogbvUpunvzf0kd8Cugk9toSJy5flXxFT+VUZF9R7/Jiz6dxWRCdOOg2abC+wFVSKgGaOWiEv7FK2MEYWYP2lKKhlzLXqvDPaoCYaU+xu85uZveYEko+9LuwMGRVQvcBwqDZicXwPFaJR2s3J3jAhbVpPFoEGxyRBQxJtDSHKpvZOhFSyUmt6UrnB9ydn6kLkYDwB6y0+HqrAuAseOU+5Dg6yA+8qTHh+UKs7jFEiPfF7ekFWBo+EsLoEuVtS7LkUW3YRJdppkfMCjMuXOObjHrfLUrUe/HgZ8T4ZYslUfL2vEN0hojI6O0sPvLFBSVeY5myCw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
- Cc: Josef Johansson <josef@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 11 Feb 2022 00:42:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Feb 10, 2022 at 05:55:32PM -0600, Bjorn Helgaas wrote:
> > Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
> > the logic of checking msi_attrib.can_mask, without any reason.
> >
> > This commits restores that logic.
>
> I agree, this looks like a typo in 71020a3c0dff4, but I might be
> missing something, so Thomas should take a look, and I added Jason
> since he reviewed it.
I concur
Jason
|
