[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 10/13] md: use time_is_before_eq_jiffies() instead of jiffies judgment
 
- To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>,	Roger Pau Monné <roger.pau@xxxxxxxxxx>,	Jens Axboe <axboe@xxxxxxxxx>,	Michael Turquette <mturquette@xxxxxxxxxxxx>,	Stephen Boyd <sboyd@xxxxxxxxxx>,	Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>,	Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>,	Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>,	David Airlie <airlied@xxxxxxxx>,	Daniel Vetter <daniel@xxxxxxxx>,	Alex Deucher <alexander.deucher@xxxxxxx>,	Christian König <christian.koenig@xxxxxxx>,	"Pan, Xinhui" <Xinhui.Pan@xxxxxxx>,	Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>,	Jiri Kosina <jikos@xxxxxxxxxx>,	Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>,	Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>,	Alasdair Kergon <agk@xxxxxxxxxx>,	Mike Snitzer <snitzer@xxxxxxxxxx>,	dm-devel@xxxxxxxxxx,	Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>,	Hans Verkuil <hverkuil@xxxxxxxxx>,	xen-devel@xxxxxxxxxxxxxxxxxxxx,	linux-block@xxxxxxxxxxxxxxx,	linux-kernel@xxxxxxxxxxxxxxx,	linux-clk@xxxxxxxxxxxxxxx,	intel-gfx@xxxxxxxxxxxxxxxxxxxxx,	dri-devel@xxxxxxxxxxxxxxxxxxxxx,	amd-gfx@xxxxxxxxxxxxxxxxxxxxx,	linux-input@xxxxxxxxxxxxxxx,	linux-media@xxxxxxxxxxxxxxx
 
- From: Qing Wang <wangqing@xxxxxxxx>
 
- Date: Thu, 10 Feb 2022 18:30:31 -0800
 
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
 
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GX+nOYxisljzrKTgPKcHNVXPHiBaBNm1rCGL/Hfu0io=; b=kSAropA30K0hq1WglqOOhRRxLrcNu9TsVIIDwPM1SPWUWsM7XKAAnoPyM4z0PjBSf6LxY/fCMmSUY6uGr1/QGD8lawlpdCk6PrY00mHlzx+ZP7Vsyo9XDr1vGwnXYlQqoGvmyaSyj3L/3PjZ5bI942KRpbcf+4D2VoLGCGGTEQ0g2yUtvglFFA1bk9P139RDTBLzydNY7G2VXkfQlQQeSszHEb/C735n/y5ntIia360JC7f8hNTrpDYhrichejbGtbFAz2zcdnMwRGpyczic0tNlWAuM41W6rGCskmzpg0jgyMY5/FIj32R6bN1G4VhQIvZAzTyL72t+VYsQHgJK6g==
 
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUyznWgZuzDBHHk8bhhKsOaQrI8+HfR4UD2AeWIqP2UBi6gGUTmvgzXGONB8c5xm+tpHE+cvnpdD5M2er7CDpItRSPpKtXanQfJghe8kqXP5MRG5vlOFjp7CgxXC3EWV0OYnO0hE6IWCkZbUWbm2NWtBIXL1GAvqWH3/h5iCdH8m1N+WeZU6db27z3w+F3RqSis2QE4e6Xg4c4DtXDNGzRJRKrpeTDL/eJ6hPWYJvpkJO0r5YnBbLqniNUFesFtWIwCqoCzmMrN6Cr32xYeCcEpJFeyfeuouH9nkgiSVfyk/07crTNlmH59H/qvq54YO70Kb9sDRYhyYyyFTTTeTyA==
 
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com;
 
- Cc: Wang Qing <wangqing@xxxxxxxx>
 
- Delivery-date: Fri, 11 Feb 2022 02:37:09 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
From: Wang Qing <wangqing@xxxxxxxx>
It is better to use time_xxx() directly instead of jiffies judgment
for understanding.
Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
---
 drivers/md/dm-writecache.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 5630b47..125bb5d
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -16,6 +16,7 @@
 #include <linux/pfn_t.h>
 #include <linux/libnvdimm.h>
 #include <linux/delay.h>
+#include <linux/jiffies.h>
 #include "dm-io-tracker.h"
 
 #define DM_MSG_PREFIX "writecache"
@@ -1971,8 +1972,8 @@ static void writecache_writeback(struct work_struct *work)
        while (!list_empty(&wc->lru) &&
               (wc->writeback_all ||
                wc->freelist_size + wc->writeback_size <= 
wc->freelist_low_watermark ||
-               (jiffies - container_of(wc->lru.prev, struct wc_entry, 
lru)->age >=
-                wc->max_age - wc->max_age / MAX_AGE_DIV))) {
+               time_is_before_eq_jiffies(container_of(wc->lru.prev, struct 
wc_entry, lru)->age
+                 + wc->max_age - wc->max_age / MAX_AGE_DIV)) {
 
                n_walked++;
                if (unlikely(n_walked > WRITEBACK_LATENCY) &&
-- 
2.7.4
 
    
     |