[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 6/7] x86/ucode: Use altcall, and __initconst_cf_clobber


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 14 Feb 2022 14:13:44 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Fi8D62XABGeWjmxtlfo7U4bG6XfsuzWSsHMcCnfDOA=; b=Vctq11h5Sn3lqyzKNLy8W3MDyZWZYKydSrAq/8tyyJ+0c7Syj+Kieqjenut5NnJi7DqEumb/99UtMi7aD5xX901q5+8opvDIfPlygz6r+aBDW9+5qH3EdeU/BcESJQYB8uUZ64VTLH9tQ6TteAl2meDmbaDHgyafXbk78DxoAh8gSpc/uKZ9dvmx7oEIWJyzFeyUsC0Bb8YLYGl3dPtOJ0OBV64vc24MXqGABS3JvGzzyzOrMoq0Qner5IhDtG+G0CwdvEDmfxe3t0Erx9DywrljWIwiZWiLKGv6o7KTXQMZxSuGL6poxjYc07bne1Jx5rT7y2tgsCO2Ymy9WY/SeA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctdBXAYTupgRdxIWOyViX0l/1EgT0qHMEfAOpssEwX7gU8TAmSqEM7sFqoconCRehBtkvDCB3ohlgA8qPfvVYykWasfXETslUDH3mjqhqrFNmoFY3obz++s1fpgzpOu6bBgUWNyzkaqUj6m1BoCNYyvCNl6sU9rGDHM84sl1bqd00//Ju7+j7Wh0Gxf9D8roGdCym+NAO+Yjwewv+4nerTeSr1Nfv8sXhTk5GV2k1qN9EXgdS1RbC65YRPIl5F/q4XoqwVtOKqXcgi6bPbRZjdWAy8GA59mVxFDZHGXAlTHCsoDiXpI5690cSjCQEbYjT5cxWXAmNwVUHHx3oIOSyQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 14 Feb 2022 13:13:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.02.2022 13:56, Andrew Cooper wrote:
> Microcode loading is not a fastpath, but there are control flow integrity
> hardening benefits from using altcall, because it allows us to clobber the
> endbr64 instructions on all function pointer targets.
> 
> Convert the existing microcode_ops pointer into an __ro_after_init structure,
> and move {amd,intel}_ucode_ops into __initconst_cf_clobber.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.