[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 16 Feb 2022 16:43:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5ywUzlXsfUlbcScrFPkd7jP1KPxdP8PhPk+LToxxHo=; b=OCzTv+B/6FElx1yf9voLK0h3eexm0Y5fNELkuq1ONO5hGbTzsqAOPe0NuQkm0tGSy5fUuuCnzMe+ulzFjaVYLkWr0cqLk/oyq+Ra5ooG06ErRVDRu8aaG5FWqOslAIlxbekWhW9qn9h4rZpqOJXnPFlf4WG/xlGbv/l7KK6Y2Snn3kNkcs698+0l7TBpm16kfnwWUn3rTyDjfwr3xZ+5DekgTSkUKBPp7o1jOOwK2rl/8dgdo7l549au5Wa5abkDhXsY1OwaTb/fZGSgb0t1TiStex2V3Fve22QGsC8YMNEvp9v9M1M/qG8EOUG+SbnRNKpDukHOJCu8XtP6eWOF/g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y5ADSu5PxkigULrPPen4VSVUPxGX0ToPyp9qB2GHMCmCxElNN50celRLl6yFgQM5gujJcl9N7XScejX2kYWv1TA4W2RmCJ4yt4lZY7+4ySiOaANrqakCdLH3awT8196EgM5+weoHHvBL9IwTUGTEEO5yH7d6WZ5wWNfF6RTBMjf7avfQ29yYVSZKaQEo/lAoV5MFgfpcrl6nG6KKje1rOcnL3OudbGaKnc5c+KOI1i+6QRxqNxeED4eodof5y3ZuavdtE1qR3PR/diYCP/UswMyD26hr5geF+pBJrf94jMwL8zDibIe3OMAEFr6HoiMUCIXZ2y455aV2jp0+IVLsiA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: dwmw2@xxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 16 Feb 2022 15:43:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.02.2022 11:30, Roger Pau Monne wrote:
> --- a/xen/include/public/arch-x86/cpuid.h
> +++ b/xen/include/public/arch-x86/cpuid.h
> @@ -102,6 +102,12 @@
> #define XEN_HVM_CPUID_IOMMU_MAPPINGS (1u << 2)
> #define XEN_HVM_CPUID_VCPU_ID_PRESENT (1u << 3) /* vcpu id is present in
> EBX */
> #define XEN_HVM_CPUID_DOMID_PRESENT (1u << 4) /* domid is present in ECX
> */
> +/*
> + * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be
> + * used to store high bits for the Destination ID. This expands the
> Destination
> + * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
> + */
> +#define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5)
Would the comment perhaps better include "in the absence of (guest
visible) interrupt remapping", since otherwise the layout / meaning
changes anyway? Apart from this I'd be fine with this going in
ahead of the rest of this series.
Jan
|
