Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Wed, 2022-02-16 at 12:37 +0000, Luca Fancellu wrote:
> > On 16 Feb 2022, at 06:18, Juergen Gross <jgross@xxxxxxxx> wrote:
> > On 15.02.22 18:56, Luca Fancellu wrote:
> > > > 
> > > Yes, however I think the parser to handle everything by command
> > > line would
> > > be huge due to input sanitisation and not easy enough as the DT,
> > > however
> > > I see Hyperlaunch has plans to use DT on x86 so I guess it would
> > > be ok to make
> > > this feature common once the DT is available also on x86.
> > 
> > Everything not being explicitly specific to Arm should be in common
> > code. Think of the work in progress for Risc-V.
> 
> Ok I will put it in common and I will make the feature depend on
> HAS_DEVICE_TREE.
> 
Can't we split the DT parsing logic & code, which is fine to be either
ARM or HAS_DEVICE_TREE specific, and the actual core logic, which can
be common and not gated by any particular condition?

This way, if one wants to add boot-time cpupool to x86 via command
line, he/she would have to implement "only" the command line parsing.

I've looked at the code, and I appreciate that it's not trivial and
that it's probably impossible to achieve 100% decoupling (at least not
without adding a lot more complexity)... But any step we can make in
that direction would be, IMO, a good investment.

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part