[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/console: process softirqs between warning prints


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Thu, 17 Feb 2022 09:28:50 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6YwBQuVDpFFptRjvFrPgL/9F6Jj/+r12HgrhapdGMXU=; b=e7MMxR0ubb6Dplrdi4XMCKIWSt0MljvBykuWEM12y5MkC4QY6Z33vpQYuNAEQsi1/YProvJ8oNY46QgcEWyU/0zHE7zARJFIhQiuWMBlGJWUpHGiJ0eOuON1yvJfOxc+io2UBrgVYCIFdtwddltP28vDdpovbOYmDIMcPR0OY79Pee3j5f5ng+Tqc3Eumo/IOUh1tj0kgf5IHIAx8ADxKGOfeIjHI8PihAmlo4WS3eKlNqlSMFeQHetiqlAXMgYNeiuarhcOPLunpQUGRcr4ZJVM0auhnvUAeFAueiRrNkILo7QrImzKpowe2UfxxaJQdbvcZpjwlJARMWED7WnShQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hg46y3+IoV2Fk8yNMRHFuCL9m5Iy8oMnVmgD6yPsS5ZVMScHyMFhqSmuAbjB5wV96z4T8Cnfmme8JCxEXowYoBGJxg62dd9/PwNzk4RtBwcXzDQM/d8F3p0b6X7jgSUR5neGcDAMCrSgsn+YVmBJ043hnFtFw9yzlW7u0YCCkiypYYcri1kj+Kw/AVVTTotYK93H8drCNslebH9hemFNUQpxsDahdxFY0IRc5pj4KnhSZneeSBn5l09s1OdxeOIZY5lHh8QUJrZnGzChVdGF8S3QTGVfc77H/S5KGE3+3or2G96EHMzmBro8ChZZZUm7eDJoPeOdvFtz+tTEmL/OAQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 17 Feb 2022 08:29:26 +0000
  • Ironport-data: A9a23:+SZlmK7UyO9zYa5Uk6TtNQxRtLzAchMFZxGqfqrLsTDasY5as4F+v mJMCDqDOarYZ2qgKtFzaNi/8xkBupCEz4M2Gwo4+Cg3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Ew2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx fEc5KDtVjYQHIL0hfkaUjhXNRhHIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmlu25kfR622i 8wxeDhyYkjSXj9zJWwFKpMkgfWjp1/iWmgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNzW6qnOZuh8XW/JLDvY3rgqKz8LpDx2xXzZeCGQbMZp/6ZFwFWdCO kK1c83BCBg+4YHIVkOk1JissC61OAkaC1Y7enpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzliPBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/pn1tp5p0xWG2DaD+qXNERz3pBZPmqgKvVlDyL9BaJpsRNMQS Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4i4DquLMIYTOccsHONiwM2ITRTPt4wKuBJx+ZzTx L/BKZr8ZZrkIf8PIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9c0xfsLyLaTr yrVt40x4AOXuEAr4D6iMxhLQLjuQYx+vTQ8OyktNkyvwH8tfcCk66J3Snf9VeBPGDVLwaEmQ v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+ dNIaH4uX4hh+3c=
  • Ironport-hdrordr: A9a23:hhT56a4sg3T3K7Ux0wPXwAHXdLJyesId70hD6qkoc20vTiSZ// re/8jzpiWE8gr5OUtQ6OxoV5PwJk80maQV3WBVB8bbYODqggCVxeJZnPvfKl/bakvDH4dmvM 8NHMZD4Z/LfCFHZK3BkWuF+qMbsb26GdeT9ILjJhlWLT2CbZsL0+6aMGum+wZNNXR77NICZe ahDtwunUveRZ04VLXEOkU4
  • Ironport-sdr: kRvO8hK4rZi+6g7zv2Ldz3cL3nG+xIo1TFjFtknMf0leHAYxDsfZmGMkDgDIGHq+nnZuLOTeon bF/BOM2n8P8rOzT3ofKM06VjfS1zFypqivd3m/YyE+iVpFmNCBkfeyWuHdZNCtg0ZCgKbLysxZ VilB78YNE/GLm8SakR5mopxZ/Ktyd+87AQLLYtqyFvhk7GMUCrJy22fEBOLBQogXzk8GY8snTw L3i9dEfVk3+PhG9qbbRLCbL1EM9lSzsrtGJUJ5wF/ymYQi/FupnPuG9WKifP7OMtYSH/dPkiia 2/Hs7KsiuT/f+qhwwu00PsE1
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Process softirqs while printing end of boot warnings. Each warning can
be several lines long, and on slow consoles printing multiple ones
without processing softirqs can result in the watchdog triggering:

(XEN) [   22.277806] ***************************************************
(XEN) [   22.417802] WARNING: CONSOLE OUTPUT IS SYNCHRONOUS
(XEN) [   22.556029] This option is intended to aid debugging of Xen by ensuring
(XEN) [   22.696802] that all output is synchronously delivered on the serial 
line.
(XEN) [   22.838024] However it can introduce SIGNIFICANT latencies and affect
(XEN) [   22.978710] timekeeping. It is NOT recommended for production use!
(XEN) [   23.119066] ***************************************************
(XEN) [   23.258865] Booted on L1TF-vulnerable hardware with SMT/Hyperthreading
(XEN) [   23.399560] enabled.  Please assess your configuration and choose an
(XEN) [   23.539925] explicit 'smt=<bool>' setting.  See XSA-273.
(XEN) [   23.678860] ***************************************************
(XEN) [   23.818492] Booted on MLPDS/MFBDS-vulnerable hardware with 
SMT/Hyperthreading
(XEN) [   23.959811] enabled.  Mitigations will not be fully effective.  Please
(XEN) [   24.100396] choose an explicit smt=<bool> setting.  See XSA-297.
(XEN) [   24.240254] *************************************************(XEN) [   
24.247302] Watchdog timer detects that CPU0 is stuck!
(XEN) [   24.386785] ----[ Xen-4.17-unstable  x86_64  debug=y  Tainted:   C    
]----
(XEN) [   24.527874] CPU:    0
(XEN) [   24.662422] RIP:    e008:[<ffff82d04025b84a>] 
drivers/char/ns16550.c#ns16550_tx_ready+0x3a/0x90

Fixes: ee3fd57acd ('xen: add warning infrastructure')
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 xen/common/warning.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/warning.c b/xen/common/warning.c
index 0269c6715c..e6e1404baf 100644
--- a/xen/common/warning.c
+++ b/xen/common/warning.c
@@ -30,6 +30,7 @@ void __init warning_print(void)
     {
         printk("%s", warnings[i]);
         printk("***************************************************\n");
+        process_pending_softirqs();
     }
 
     for ( i = 0; i < 3; i++ )
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.