[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 17 Feb 2022 16:50:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=koOWlH8ydSAqujxyjK1NQtAxTr+mx/9U1EGpVfw8e5w=; b=nlujufLqctb56JMy76SJGSbI1iXZ/mUmB97aG7Ucbl6pn/FJ3qhyGduVLOsOBkxfaQN36zyJQGV9aXWAfcYcDWZPmCCjdd3IX3rzYdlQZphRecUsKfEw6MX3n6+zvt4gE4Di9QIU/aHljxd7CTTnxIPr5XI1kX55bSieNuaEIZnr+ZBPMIkB0bgkjb5rtvN45PCLBhvk1fTaNUBD+AMe78x8GPUgTLNmvd301ncfethOkGtYvnQYjsNsPnGkkb989X2I7zfERnLrwzeyN3o3CUo7iOz3RNh5pFc3ua6Y4jwdeCXyQlbcH/UnqBkmgoL3pot4MHqEaxrzGeOK6811Yw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HVwy/fv9IdQn3yliLflSQyEm1eze9lx+K/IN/XCUR/gcXd0/e7wl9LC1GGfDA37iT8kPCJn62n4JzWYADXqR0zygqRNjwwTbwGAbR9kgVJc3J1I+I6qPyUHwTjPqnUjUC4Hh6zWl8J1hcYqVhWlLNYaegbQtdFhMl1qSJ/jO06WH1CZ3tiw01KSJLpMOW7FdsNC0G8jJlkddaL5Od+4yb9wR04rYhkX0XncEk50GWxs38AtbTQ7dvKzEyD6ompqwbO0ZXzkjqASZmMAMQsY6bQ/QZiOqbeTQndr3COMJfEH12D7nrY0wWsQiA71b8iGPwD2jg9Stgln9bxXwC2md/A==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 17 Feb 2022 15:53:02 +0000
- Ironport-data: A9a23:yWs+qq+JfK+Z3jrcc2/wDrUDXnmTJUtcMsCJ2f8bNWPcYEJGY0x3m 2sdXmyBbq7fMWLyfdtzaIvl8EwOv8LdyNBnG1Ftqng8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3dYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhxy 88WvLeNVT41GZ+Xm88EDz5XNxphaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgGts2J4UQ54yY eIjcmFGRx+RfyRVI042Wb4Ds/aQr3bgJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc QpOoHNo9PVsshzwJjXgY/GmiH6HpEUVcOdMKvEd2lqO4bOIxAm9PXdRG1atd+canMMxQDUr0 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNslIRiG2NPdXABb3nARBodtnxor6p5 iVspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/INgLv28ieRw2b67onAMFh meJ5mu9A7cJYROXgVJfOdrtW6zGM4C7fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z uuzwOPRmk8ADrOvOXiMmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl kxRkGcCkgGXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
- Ironport-hdrordr: A9a23:imhk0KqQSqtxvui+/p0zcSsaV5uzL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK g=
- Ironport-sdr: 4q56oXGDLr+A3UgP7yg6nzt5T22SEW+lgLxrZ4cn8WH8e2xxkjo87Iaq+ARIuBJOojvYpVqVLW vg9CbsGd2pg2m2aV5A3I7c27JxfMpKLjuhFUMl8N0zLBAUyQVYgsiRBGecjmabRGyUIeJFuBKY s0UiG65sI5tvbog47wi8m8YJYf6f+ZWRj0rV1xSiiXFtcE3fTbGF2Od5Ia5tr8PXMlB3NLFoDF t1X4NZqaqw/UjQvBu7IYvk7wygh3jjvhn1NFg/PEyzqSb5pfep/PcmphIe5kDaSR/VV1zuK+De wekmCDaj9mc7koxxbrvR66ED
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote:
> On 17.02.2022 15:47, Roger Pau Monné wrote:
> > On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
> >> @@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void)
> >>
> >> static void lfb_flush(void)
> >> {
> >> - if ( vesa_mtrr == 3 )
> >> - __asm__ __volatile__ ("sfence" : : : "memory");
> >> + __asm__ __volatile__ ("sfence" : : : "memory");
> >
> > Now that the cache attribute is forced to WC using PAT don't we need
> > to drop vesa_mtrr_init and vesa_mtrr? The more that the option is
> > fully undocumented.
>
> Yes indeed. You did ask to re-send this patch in isolation. This removal
> is part of the full series.
>
> >> --- a/xen/drivers/video/vga.c
> >> +++ b/xen/drivers/video/vga.c
> >> @@ -79,7 +79,7 @@ void __init video_init(void)
> >> {
> >> case XEN_VGATYPE_TEXT_MODE_3:
> >> if ( page_is_ram_type(paddr_to_pfn(0xB8000),
> >> RAM_TYPE_CONVENTIONAL) ||
> >> - ((video = ioremap(0xB8000, 0x8000)) == NULL) )
> >> + ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
> >> return;
> >> outw(0x200a, 0x3d4); /* disable cursor */
> >> columns = vga_console_info.u.text_mode_3.columns;
> >> @@ -164,7 +164,11 @@ void __init video_endboot(void)
> >> {
> >> case XEN_VGATYPE_TEXT_MODE_3:
> >> if ( !vgacon_keep )
> >> + {
> >> memset(video, 0, columns * lines * 2);
> >> + iounmap(video);
> >> + video = ZERO_BLOCK_PTR;
> >> + }
> >> break;
> >> case XEN_VGATYPE_VESA_LFB:
> >> case XEN_VGATYPE_EFI_LFB:
> >
> > I think in vesa_endboot you also need to iounmap the framebuffer
> > iomem?
>
> Again part of the full series. I guess I was a little inconsistent
> with leaving the VGA unmap in here, but breaking out the VESA part.
> It's been a long time, but I guess I did so because the VESA part
> needs to touch two files.
I think you are hesitant to include the chunks for the above items? (or
maybe I'm not properly accounting for their complexity).
Thanks, Roger.
|