[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer



Hi,

On 16/02/2022 07:20, Juergen Gross wrote:
On 15.02.22 22:13, Julien Grall wrote:
Hi Juergen,

On 03/02/2022 13:14, Juergen Gross wrote:
Add a comment to include/public/grant_table.h that GNTTABOP_transfer
is deprecated, in order to discourage new use cases.

 From the commit message, it is unclear to me why we are discouraging new use cases and indirectly encouraging current users to move away from the feature.

Patch #1 seems to imply this is because the feature is not present in Linux upstream. But I don't think this is a sufficient reason to deprecate a feature.

A more compelling reason would be that the feature is broken and too complex to fix it.

So can you provide more details?

It is a feature available for PV domains only, and it is very complex
and hasn't been tested for ages.

Right. To reply to Jan's e-mail here, shouldn't we also de-support (either completely or security) in this case?

My concern here is you wrote this code has been untested for ages (not clear how long) and complex. So potentially this means there are security issues in it.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.