[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/3] retpoline: add clang support + Kconfig selectable


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 18 Feb 2022 15:45:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WKNIonxcahKNHrmTDcEKSy7WRj7ghI/H77ZzKPmKQEo=; b=iOGxMWB3//CzdZOxTrhD7uIC+HLcbp+DApr2qvs6VYIcp7ij7LYE8xlUonIJnAs0wSdgEnGSouMQLbHPagw6JTVe3EuZSnTrcfdnyMcB0gtLVb5W8TH5dCeBNRPxiT92vzrwK6zGX96d/YmGYI8Fo8+unbwsQttZVaG/0lRXJFEo8UpVdNXGDhrOopYJC/r7joIAM4VxkXnRwknp1CNk1tsy4KW0vtfW3Yv0vJ8YpTIsrR2eow7eUA5hGVNlmckc05D8KKjYnbk1y+ChuOLnH52+DlD/Avt8eQJqy5KjMy+j+Q6D8UP239Y94wrCL2laslSEWEGcL+0XnN4X/5AjEw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zw3d3d/u/V+J+pE+t+IpiC9VXT0G7AsWxoNxKdYUTmDgEsEiUKfU7bdY9vcrOPom3kd4fqRcT53pHGwPqPh37RKtW+2SLAgQ3a4i/re9pwFBnexb38b/Ob+zxg5ntvMPlCaTc9oCeBPiymkEuo8Ps/GJ4OJMbcn0VWm5MXVGerT7HSkjBWmA2pfAPPn4bsuwA61Xmtjc0Y+q7ELJ7hKApnd8Gp7yJfcOGuzm10L+r1ie8KYdIqmu8R4Vu67oXAF2C9/9cnS1ttEI5onpDraTWFHEpIDLVNTleaMDvzZM4AjLhVuyn5a1W9YJBTVHXmgUZ1Bn7PbjritdzMO1TucHtA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 18 Feb 2022 15:45:47 +0000
  • Ironport-data: A9a23:cd4gz6t8cD6bKVl+nlEhWkMg++fnVJteMUV32f8akzHdYApBsoF/q tZmKTqEOarZMDP2L90kPNyz/E5Vu5XRydNiSQVuqXw2FyoU+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nU6 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8rHpTiuOQlciAALCR8OY1EpbT5HFKG5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD yYcQWQ0PUqePEUTUrsRIK89mt6HpH/RSmNBqU+ZrKcroFHL/hMkhdABN/KKI4fXFK25hH2wp H/C/mn/KgEXMpqY0zXt2mm3mubFkCf/WYQTPL617PhnhBuU3GN7IAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOiSMtbWV0j BnTxYqvXGEx9u3OIZ6AyluKhTGSAAY1LVcjXHc7SAkBw9u+q78OpCuaG76PD5WJptHyHDjxx RWDoy4/m6gfgKY36kmrwbzUq2ny/8aUF2bZ8i2SBzv4tV0hOOZJcqT1sQCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJq2XFF52LJ9k4DNRCyKFBa5dsldjBO hK7hO+pzMUPVEZGl5NfbYOrENgNxqP9D9njXf28RoMQPsUoLlPfrX0wPBT4M4XRfK4EyPBX1 XCzK5vEMJrnIf4/kGreqxk1itfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2JOAn86MfbNzNsJIso990ijvryTp S/Vt44x4AeXuEAr3i3QNCg4Meu3BcwXQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV P4LZ4OLBfEnd9gN0211gUXVxGC6SCmWuA==
  • Ironport-hdrordr: A9a23:NJZt7K3YFZdzeQANZ3kZfQqjBRRyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5AEtQ5expOMG7MBfhHQYc2/hRAV7QZniYhILOFvAj0WKC+UyvJ8SazI9gPM hbAtBD4bHLfDpHZIPBkXSF+rUbsZq6GcKT9JzjJh5WJGkAAcwBnmRE40SgYzdLrWF9dMcE/f Gnl616Tk+bCA0qh7OAdx84tob41rj2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E De+jaJpJmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF5d1HqWxa1O UkkS1Qefib2EmhJ11dZiGdgzUI5QxerEMKD2Xo2kcL7/aJHg7SQPAx+76xOiGpmnbI+usMjJ 6jlljpxKa+R3n77VTAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdo99Q/Bmcsa+d NVfYvhDTdtACSnRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtZ5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdA15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAX23G4gMy0eFPGC1z3dLkeqbrXnxxEOLyoZx +aAuMjP8Pe
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYJNSfcDAKqGNVbkqTBpzLddC15ayZc12A
  • Thread-topic: [PATCH v3 0/3] retpoline: add clang support + Kconfig selectable

On 18/02/2022 14:34, Roger Pau Monne wrote:
> Hello,
>
> The following series adds retpoline support for clang builds, and also
> allows the user to select whether to enable retpoline support at build
> time via a new Kconfig option.
>
> I've tried adding a suitable description to the Kconfig option, but I'm
> sure there's room for improvement.
>
> Thanks, Roger.
>
> Roger Pau Monne (3):
>   x86/retpoline: split retpoline compiler support into separate option
>   x86/clang: add retpoline support
>   x86/Kconfig: introduce option to select retpoline usage

Thanks.  I think that's looking much better IMO.

One thing, we want CC_HAS_* for consistency.  I can fix this on commit.

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.