[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/hotplug: don't install init.d scripts if SYSTEMD


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 18 Feb 2022 23:40:43 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d1t8B7JvqtxBgtqAw0NwLR4XdNVHjjInxr42Sm1K8ZQ=; b=MwKuucxYqIaVXxv40JIlFJbAa2ZdMVJDOWpjF5QP21qnnSdt/4gRSzP9fh7qxt9mOmoJpZjDPgDRNZ0X4y4PoErr8i6fVK/nKNQNh2S8tCwXnKCdKAfUu27n1g2FXtMG53t9D3hha4FzDvjKASaC5T2zSaMDrjy+OLxDwPKKaOTUOmTrfH6c815Wbdg+I0JQm2WzxIK55K8khlrYwg9KKVv2g96agFBTR10dfLlqRAjuPiEL60HccLwLTi+mm4kAVRQzEbkKsAgPvpegL5W+tvodUs6SgLQUSBhc/cxxQAG20w9WD/KhOdW9vbsKdO1qq43l7WYPiq7A/i3acd5ChA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pd9KD45R1JEZFRDevwDqR5tNm26MWPAA0VLd1qpHDXJRU6qq3dMlCdsGnmiv/VQbT6H0SgvdPJJJL/WvAqIxkmgM6iiSAInFWSf6rRRbhCZp5W37NZ+xtfn+V5V9bxhNflcgZwJJwuOSOI/gEyA87HtEHy8WmRATKtlTos9rzrDcidYSEY8ewzbOw2wyC/7B7biDMLU2sx1Chgflw6xi035DFMmt2hjwed6bm7zFQkRAtNmxxq5LTTxx+g2m48EUDL/Nkz45uzI7/CtFOfrqUzD+cO3rLvrd20/yDhkRuBjnWFFba8LPS0ccirxlVEp3cvB0Jg02Ikm3oBOYsdZRTA==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "christopher.w.clark@xxxxxxxxx" <christopher.w.clark@xxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "bertrand.marquis@xxxxxxx" <bertrand.marquis@xxxxxxx>
  • Delivery-date: Fri, 18 Feb 2022 23:40:57 +0000
  • Ironport-data: A9a23:lJIqbKD2+Yy62hVW/8rjw5YqxClBgxIJ4kV8jS/XYbTApG4kgzUOz DMZWzjSP/yNZDT9fYolaYm1900Hup/XxoQ1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg0tYz6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhR4 +dXhYWxbjwrM5TLmtRFXEhHPn1xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4QTa6EN 5RBAdZpRAvwQUJLZnYdMrkZmeuavVjwKjp693vA8MLb5ECMlVcsgdABKuH9cdyQRN5JmV6Yq 3iA4CLyBhgAN/SQzDOE9jSngeqntSH0QoUJD5Wj6+VnxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM GQd4C9opq83nGSwVcX0VRC8pH+CvzYfVsBWHul87xuCooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9EIMZTXZaF01fuYCl+dxtyEKUJjp+LEKrpv3eKyvA2 jGtlyozvrIRvZYEhrqWoV+S1lpAuaP1ZgIy4wzWWEes4QV4eJOpauSU1LTL0RpTBN3HFwfc5 RDoj+DbtblTVs/VyERhVc1QROnB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCH17YSPCgUxfOdvZ5yEWIU7IT4iNuhf8NIcmX3SJXFXblByCnGbJt4wXrGAikLskJ bCQetu2AHARBMxPlWTqGr1EieR1nH1nlAs/oKwXKTz9jdJyg1bPFN843KamNLhlvMtoXi2Om zqgCyd640oGC7CvCsUm2YUSMUoLPRAG6WPe8KRqmhq4ClM+QgkJUqaJqZt4ItANt/kFx4/go yDmMmcFmQWXuJEyAVjTApyVQOi0BsgXQLNSFXFEAGtELFB5P970tf9HL8FfkHtO3LUL8MOYh sItIq2oKv9OVi7G63Iaa5z8p5ZlbxOlmUSFOC/NXdT1V8cIq9DhkjM8QjbSyQ==
  • Ironport-hdrordr: A9a23:V32VMq7lncXbbb7XKwPXwDLXdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYJR+qUOfXagHVfEujp222vc98OqyZ96IA
  • Thread-topic: [PATCH] tools/hotplug: don't install init.d scripts if SYSTEMD

On 18/02/2022 23:30, Stefano Stabellini wrote:
> When Xen is configured with --with-systemd currently both the systemd
> init scripts as well as the traditional init.d scripts (e.g. xencommons)
> are installed.
>
> This causes issues to distros where old style init scripts are still
> supported even when systemd is enabled, e.g. Yocto. The consequence is
> that xenconsoled (and other daemons) are executed twice resulting in
> errors at boot.
>
> If --with-systemd don't install xencommons and the other sysvinit
> scripts.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>

I agree with the intent, but just because you want the systemd files
doesn't mean you don't want the sysvinit files.  (Also, I've been trying
to persuade Alpine or Gentoo to upstream the OpenRC config files too,
which would make a 3rd).

There wants to be --with-sysvinit (defaulting to y) to controlling this,
at which point a packager can chose any/all initsystems worth of config.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.