[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 21 Feb 2022 12:21:08 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7HJSCi6QRDFHBTnJs9UufTYNWmzrJqGJ4dR+pYk6nBI=; b=ZCgrRhx0Q8E7HrbWJTMqXs/scfu/4FA4DfY+wbI0cU6VP+S+xa3QqtovnIJr+H9mgPXDOcxxt16J7QWZq3+hif4DETLwdMMCII6d5UYxR/rUlVZdLBBgDUUckjMuGcAjHqvK5bVqDCMH21EWhlVjacI7MUQm7lRUj5HKK4NIa6AbCmyZHB7bowYxH17f8BNEdKQb+SDcNDvKYtBVrekMyphpRvNYivspbz5xjGQxUVFqTlsSQROliM/ir+PzgGZHEbLhaHkLPZSAS0E29fdtt0g/Vh8Y1PmdYw2lD32LVafuxP4KGXP+Nb8cstpRWp8veH1PPDbbaHDyrtmW1BCytw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ihsyA9IwRqPkNIvD3sngqwPAhdcVP7WCjL3Ux07LzDs1rLrgadeYoIzkUTRHnUC2485arSMB+Vdcn9g4NMcWjCFH4p4+8WdCAsntH0fwjTUZuS0sF9B0PNJPZNzaqWnQ9J8yHMrnxDuKJE6knqntl9acz8/qskoisKmqxiDPNFAGr7OMSFW8gaGylUSsZL3vRA5YozNBTCMn/xOas9kGpZt6VRzsWP4IXZjhBzz0WMZI+VmlMptI5OqHVrAJNrKgux1zXqdrw4TILazx3rAFGD5rqfTKcKSXcoPV9La8IsGX3oQupK4F+fQYsyOMQgkAF532wf3zkt/ToCXkiu/BHw==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Mon, 21 Feb 2022 11:21:26 +0000
  • Ironport-data: A9a23:Y6NuaK7luhaOQg0i7WS+bQxRtO3HchMFZxGqfqrLsTDasY5as4F+v jQfXG+GaK6KMWv8LoxxPI2ypEsG78SExoU2G1BtqSA8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTuQh55DvzotN4ZThhoAidPObFdqY7udC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQ6aOO pBBNFKDajzFXyJsfQYTJ6s/hd+wiSH5XDQHq3Ss8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv G2u12bkBhAXMvSPxDzD9Wij7sfXlD7/cJIfEvu/7PECqEaI2mUZBRkSVF26ifq0kEizX5RYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84hmbLngJSCZbb94rv9NwQiYlv nertd70AT1ksJWOVGmQsLyTqFuP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLTqWs3u2kPR3Kx y2LnDk4trEPlp86/vDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl D1dwpXFsrhSZX2YvHHVGI0w8KeVC+Fp2dE2qXpmBNEf+juk4BZPlqgAsWgldC+F3ivpEAIFg XM/WysMvve/31PwNMebhr5d7OxwkMDd+SzNDKy8Uza3SsEZmPW71C9vf1WM+GvmjVIhl6oyU b/CL5rxViZGWPk2kWDnLwv47VPM7npjrV4/uLihl0j3uVZgTCX9pUg53KumMblisfLsTPT9+ NdDLcqaoyizo8WlChQ7BbU7dAhQRVBiXMieg5UOKoarf1o3cEl8WqS56e5wJORYc1F9y76gE oeVARQDljISRBTvdG23V5yUQOmxBc0m9SpjZ0TB/z+AghAeXGpm149GH7Mfdrg77u1zi/lyS vgOYcKbBfpTDD/A/lwggVPV9eSOqDzDadqyAheY
  • Ironport-hdrordr: A9a23:1aWSGK2oTSye30xDLy0MqQqjBV5yeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu vh2iMLnUvoRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIF/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF8nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvWOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1rop5PzuN+d3B+3Z W1Dk1ZrsA+ciYoV9MPOA4ge7rBNoWfe2O7DIqtSW6XZp3vfUi97qLK3A==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Feb 21, 2022 at 10:02:53AM +0000, Andrew Cooper wrote:
> Coverity reports that there is a memory leak in
> ioreq_server_alloc_rangesets().  This would be true if Xen's implementation of
> asprintf() had glibc's return semantics, but it doesn't.
> 
> Rename to xasprintf() to reduce confusion for Coverity and other developers.

It would seem more natural to me to rename to asprintk. I assume
there's no way for Coverity to prevent overrides with builtin models?

I've been searching, but there doesn't seem to be any option to
prevent overrides by builtin models?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.