[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 21 Feb 2022 15:13:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zp1I+RrgdDB2yriKTJYhFfVm2mtAsDk+R6DDnfd16UY=; b=nsfQtQI3DoukJwoZxCALPezp5uUk+iWv1b/3wAP6Yin8L/gn0eGlE5+Bdc2RjF6Xc6+EFNfKUt7Jiw3X1nwWjBe/9MHl7MzfytKdhOGzP7BfCogP4ak3iYWdELUj/n8484jPXeocIL/Vhg10hYTXWyvghxJSazh5883tNXYe6KPYxjDNgzpUwwbWSMb2UGBXOFbNAXy9iSF8WvOJQomdm+uPMiemm97MnH2XTSjiIWE/LsHCogSFiEhZ+rQ9F9o3HRek08osoDYdSNcnZfumiRKlUCg5iR/Ju8cxLKym/IS2KtPhAFysg68nzPen9CnekAMnsjM/bpzPSHwa9YsDTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUa7gIiidOQrOMazQIdPUdS2sQYjRzYIi+9aJ1m2SM2arm6YMuKUCPhq1i87SFK2GBBtjFyDdQSuLBJWQSbCO/vhLVodHGP38iPnOCZTZ3msZhhaEZUgQTUb6jZUsJlqE8Y3iFbvzHMHfKECQvcOSGOeiSoiGcJPn9tc8I/tBORi3LXcfYu+uvXceVud6RAnm2PPDkIEx3VIrf40LYS26+bJb6c0B5NYhOclYJXtTaw9hzuxMX09QXEP6HwnaqPGkr10bTVEui2YLvI6GHwGIjwLhCbrxajzFExr/gFPhk6i2qMm5252pRFo2IrBJ5dpRtF8qCzMqiPohHplwL8IgA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 21 Feb 2022 14:14:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.02.2022 11:02, Andrew Cooper wrote:
> Coverity reports that there is a memory leak in
> ioreq_server_alloc_rangesets(). This would be true if Xen's implementation of
> asprintf() had glibc's return semantics, but it doesn't.
>
> Rename to xasprintf() to reduce confusion for Coverity and other developers.
>
> While at it, fix style issues. Rearrange ioreq_server_alloc_rangesets() to
> use a tabulated switch statement, and not to have a trailing space in the
> rangeset name for an unknown range type.
>
> Coverity-ID: 1472735
> Coverity-ID: 1500265
> Fixes: 780e918a2e54 ("add an implentation of asprintf() for xen")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
