[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status existence before watching"
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 22 Feb 2022 09:31:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vE18hdZ9uVAnGW50XqiQx6/cqbsWACrD6meOYQdWLa8=; b=iSkkgr0dJJgtJz2/CzKnmzUKyNwHYOg7UTAAAQDZiszYcXLaWMX8lBfccHqisn1+R6DiBIPloB5lEtxFgUsorEfIHallqnOytqZDHIEpuPzES3Jj2jmU1pnHsDEs/x6XaCXF32tCW46cSmoc6y939eRIHvSTtm5f7axla5lGuR+j4doPEY/H1LHLp6WFU+9DlNd18XzbND9YfrKS49uMMse/H5E/ZNfIhLUEa8kqxM0sDFEWwRFSOJsLRN6fDhJJ6y9oDC714ZPPqX5J6CuTLBeIDErgA2+A0XdK8LJHUwUShKJCfdw5uuq128NGkOKhJu5J4q3BNCE83CEmPiDsiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cRA8TnYsZFZsJj9VD5at8Znpn1W1EGg0YE+MmUBQFvyfcHx5i77+Mlhlh0dzZp3mYwWo75YEbQ/z9K6qNur5LwrGZGb9bK34A5meOEtxrlNOZQ9Hh7GiVgxGdClxyUCYEWI1SUwtpHMBDBmee1p0oKGhng1WwV0gksOzE6weKfwfBVvi+YA0uuUOPtNQ3IaiuPMfJ6zhk53F2fhTk4lEgPWwRK1JDZhAhD0AL1WQOD+imFiPAEV8En1po6zUIod8g8+CpvhAZvD4cLgHZGlCBirjdA/RAzaJ3Mf1m36O0XmU70erTEj546WGBI/fsCKxl6FGSCpjJCjBMYJshz2NeA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <stable@xxxxxxxxxxxxxxx>, Michael Brown <mcb30@xxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "moderated list:XEN NETWORK BACKEND DRIVER" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:XEN NETWORK BACKEND DRIVER" <netdev@xxxxxxxxxxxxxxx>
- Delivery-date: Tue, 22 Feb 2022 08:32:24 +0000
- Ironport-data: A9a23:1dA6L6JS5VF33+6hFE+Rb5UlxSXFcZb7ZxGr2PjKsXjdYENS0DQCn WJMD2yHb6mLZmOjctB1Pojg8UNUvZKHz4Q1TgJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQy2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Mty6LqpdSUAB5zzsr4bD15oOSBEF5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls2ZgVQaeED yYfQQFUdimHejRAAxAwA4gsnue6lGfWKTIN/Tp5ooJoujOOnWSdyoPFPNPLd9miScxLk0Oco WzauWL0HnkyLNWCzRKV/3TqgfXA9Qv4RYgbPL617PhnhBuU3GN7IBsbSVe2v9GnhUOkHdFSM UoZ/mwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsSj9Hdcxjt8IsQzEu/ kGGksmvBjF1trCRD3WH+d+8qDqoPCEPIGwqZCkaTBAE6d3uvIEyiB3USt9pVqWyi7XdAi35y TSHhDYxiq9VjsMR0ai/u1fdjFqEuZXICAo0+y3UU3ij4wc/Y5SqD6St4lKAtd5BNJaUCF6bs xA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP0n2EyOYAd1R2UykGJJ4YMpwFUJX1DC5NREdP2W 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa6NMIcXCnRlXErepXw1OxbMt4z4uBV0yckC1 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59YaDNijchjtctoRTk5F f4FbKNmLD0FDYXDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdA4w/oEy7qSo ijlMqO99LYZrSecQeltQio+AI4DoL4l9S5rVcDSFQzAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ 8TpiO3basmjvg/vomxHBbGk9dQKXE3y2WqmYnr0CBBiLsUIb1GYpbfZkv7HqXBm4tyf7pBl/ dVNF2rzHPI+euiVJJyIMKn2lwvp5xDwWotaBiP1HzWaQ221mKBCIC3tlP4nZcYKLBTI3DyB0 AiKRxwfoIHwT0Udq4ehaXysx2txL9ZDIw==
- Ironport-hdrordr: A9a23:fm6rjKhLHOF8QC3j4ROq6RqHqHBQXt4ji2hC6mlwRA09TyX+rb HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Feb 22, 2022 at 01:18:17AM +0100, Marek Marczykowski-Górecki wrote:
> This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.
>
> The reasoning in the commit was wrong - the code expected to setup the
> watch even if 'hotplug-status' didn't exist. In fact, it relied on the
> watch being fired the first time - to check if maybe 'hotplug-status' is
> already set to 'connected'. Not registering a watch for non-existing
> path (which is the case if hotplug script hasn't been executed yet),
> made the backend not waiting for the hotplug script to execute. This in
> turns, made the netfront think the interface is fully operational, while
> in fact it was not (the vif interface on xen-netback side might not be
> configured yet).
>
> This was a workaround for 'hotplug-status' erroneously being removed.
> But since that is reverted now, the workaround is not necessary either.
>
> More discussion at
> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@xxxxxxxx/T/#u
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> I believe this is the same issue as discussed at
> https://lore.kernel.org/xen-devel/20220113111946.GA4133739@xxxxxxxxxxxxxx/
Right - I believe we need to leave that workaround in place in libxl
in order to deal with bogus Linux netbacks?
Thanks, Roger.
|
