[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
- To: Michal Orzel <Michal.Orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 22 Feb 2022 08:48:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LyMy87wvyZ62c9vWLLoO71oN0aKj5HlXRnDLhTiB9DQ=; b=ACxw5pB9+cFjB77vcfBqxN2EOhIbUYRsOjxB+8terEiNgNWIT3gOqzE/Q4nPx80mgA6LfXUelhTZPIcMzxRuNFHsNyMu/k3HJe5ndmqxm5TniivsRmMTd2aZI9UtotHDaH9OEzvWUofR3rWdPWF0OW1rqA5Qa+DANbQbRWwoJcDi8P+yjv5DTUZTadZGWnafj3EvtAXpIasPkyHTT3i+rjkqkICMUgiDxncP8fxV+zMGYSVEoL9fP9hFD1nCqk2yR4/6W7Q8MJRuC3NFmbSTDZteMKl/zJjKpb2yjJa1lRqe+Y/nTxYSDG25J5WTTjbot+9WbMSnTghr8PETOsxUkQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K8IbaYsCrCahWyz0wUv9R1aou9A3fxqT+wfuq0VKck2/lXOiszVQToBl77YmOolxC0cQWYzugldsKA8WFfR2v727eGL1RWU8nA/aOHreVyMT6yZvq4ibwsMJU1cFVKYLHuBhh5llujPjgYtw6U80ae2CeC2FS+k/Vzl+9e6kxqsnLjfwhNh1JwPR3xAWNfs61EYbZaZqFF5qZhbuG3hpLuMpf4lZjBMcy6Uikx5M71w6nzW8TmO1i2+x4QmqKJ6CyZu8K15qw2J65P7izAam2+l9mxzW/LrGgPj7Ql+Fpt9/4PVKNPdHPxOxPWSMnEpUbElSUAzwA/nMmQeKc8w4cw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 22 Feb 2022 08:48:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYJxJCWcqEO5mjnU2pXdjeX/mYYqyeKbmAgAD9y4CAABwvgA==
- Thread-topic: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
Hi Michal,
> On 22 Feb 2022, at 07:07, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Hi Julien,
>
> On 21.02.2022 16:58, Julien Grall wrote:
>> Hi Michal,
>>
>> On 21/02/2022 10:59, Michal Orzel wrote:
>>> Following a discussion [1] it seems like that renaming work has
>>> been forgotten.
>>
>> This is in my todo list of clean-up I need to do for Xen. But I haven't yet
>> had a chance to look at it. Thank you for taking a look!
>>
>>> Perform renaming of psr_mode_is_32bit to
>>> regs_mode_is_32bit as the function no longer takes psr parameter.
>>
>> If we modify psr_mode_is_32bit(), then we should also modify
>> psr_mode_is_user() because they have the same prototype and we should keep
>> the naming consistent.
>>
> Ok, I agree. Do you think this should be done in a separate patch?
> FWICS, psr_mode_is_user is used in traps.c, vcpreg.c ,vtimer.c and vsysreg.c
> whereas psr_mode_is_32bit - only in traps.c.
I think it can be done in a separate patch.
Cheers
Bertrand
>
>>>
>>> [1] https://marc.info/?l=xen-devel&m=156457538423787&w=2
>>
>> NIT: The first sentence and this link adds value for the review on the
>> mailing list (we know where the request came from) but doesn't add any after
>> the commit message (there are no extra information in them).
>>
>> So I would move this information after ---. This will get dropped on commit.
>>
> Ok.
>> Cheers,
>>
>
> Cheers,
> Michal
>
|
