[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] x86/perfc: fold HVM's VM-exit counter arrays
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 22 Feb 2022 10:40:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gS7/inIPKvQqZhZqlMazaIgUzDQJBDKHdhDYzlWVE6M=; b=ZudpLpowN8PrX3kK3BVU76u+c8R0wUA7NSxETxCvkLmLyRyualdR44jw68p5bJdGxcpX8BPOoy//1ri0g07aIW47n09iGM8DIZLE4QTAfaaf0QrrjApy4kaocKNt7jo9i1msfl2oWp60DS/kA6Cxv0AGi8KUOsAY/kYSih2PaVnY+/T0C/+zH04n5LQSSrcCFbWhH+TzVevrLDc+olPia/1jQFhmjUqY4FfE1ixg6ZymeMnAeMOHEWqwAxyKr97g4M1+f5ma0UfrJm5MaVPUX+LFr1Iv8rrcRxqjZD/k+fPwOgWFjA/f/VRoD+US46DxPbF3vBg1l5KcyDpZFfA4eQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOCtQeYEQ3DcsaTTpnrU1LOSxmWmAnWpaZKyCtJfkcxwGT38syjgFsITKs9dWVf82NxzorfRXuaG4Ck0xb2vxJYIm57+AGEuhCPwl32sSbtqRVgPQM8ox8LbMJXJgGtxz9VDUiLT+pzjSm+dn/xQ1c/M9wGIc9p3rpbPMJ7aHd2RS63gCqZjnF1Znvn3zPcpd4e9WcoNI09tG+NZDRBQpJPzM9sCsbR+VD60+hbaWe4P42MN5S4/uzDyLNN9v0NpsO1Nn0xVBH+WdQ4tHnhoeDXGLp3vFM96P4KAMb4lp+0Vnnm7liaaqHnvhyuOAu/F1mjn1nnRCf+/TjcUW+ZfUA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 22 Feb 2022 09:40:32 +0000
- Ironport-data: A9a23:BJD/I6OplIR9GBTvrR2yl8FynXyQoLVcMsEvi/4bfWQNrUp2hGcCy mROWTiPbv3eNGX9fYwnb4q3/R4C7JaHm4RiHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2NQw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4 upH7pObdwIVPbScuuVCdxxoMT45FPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmtv3p8TRqy2i 8wxRhd3fiTjIDh2OmwFFc15w935gWiiSmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd RZSoHB36/Fvqgr7FbERQiFUvlaugRRHVPFuFtE58VGvy/Xw5ja7GS8tG2sphMMdiOc6Qjkj1 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzCJrVml CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9Id0MvmAjeR01a55sldrVj Kn741g5CHh7ZibCUEOKS9jpV5RCIVbIT7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im +ti2zyikUsHC7SmOnGNmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl kxRkGcBoLYjrRUr8Tm3V00=
- Ironport-hdrordr: A9a23:Zd76H6OP7uaA7MBcTyX155DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/ Gnl7R6TnebCD8qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPof2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7vvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wA9HdwGOt15Dt //Q9ZVfYF1P7wrhJ1GdZI8qOuMeyXwqEH3QSqvyWqOLtByB5uKke+x3IkI
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jan 05, 2022 at 02:59:03PM +0100, Jan Beulich wrote:
> Only one of them can be in use at a time, so make the whole set union-
> like. While doing the rename in SVM code, combine the two perf_incra(),
> generalizing the range upwards of VMEXIT_NPF.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> v2: New.
>
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -2644,7 +2644,10 @@ void svm_vmexit_handler(struct cpu_user_
> goto out;
> }
>
> - perfc_incra(svmexits, exit_reason);
> + perfc_incra(vmexits,
> + exit_reason < VMEXIT_NPF
> + ? exit_reason
> + : exit_reason - VMEXIT_NPF + VMEXIT_NPF_PERFC);
Should we assert that the index used here < SVM_PERF_EXIT_REASON_SIZE?
Just so that adding new exit reasons without increasing
SVM_PERF_EXIT_REASON_SIZE is not likely to go unnoticed?
Thanks, Roger.
|
