[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 22 Feb 2022 13:10:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EMSs3Mnykf+UVOFzLYEo/yZydukXZAZCFOlc+Trqxms=; b=Mdh40Yj6N0FLEizutUbQktv+bdLW/2dXeC08MfgE9mo2HTHC0eQepHyO4XssH02QguU4UESwqLtocB4W2i/yjD7I4M4zk/dfwrvB6yX3SUOCianRePWfqglR+H5nGU4F8zbBSWcno0GYa80eLCzM/4EmiD0Y4YqNyEmrT5ud54fDTnYNNMPmqa26aRatRZfY/K8ZeaBTa4DuLWmm2xVGeJpzPLOjxIOgU+Eh2W6YypreqfpFO7iBwl9AIyUapwGjQEwM8PHpdrSErtwu1h1kmfd4PLpfwuHjSuDJvpcj9/hLxeVZRGzIHlMu0Vp56711HKiy5i2nzJu0hTjSv09QlA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IH+OBYVTQ+6+S5mKAPRp+zV6HtAlpCNLRLMgW5MeEIGS4CpA0EB9jxpMm69cdjxYxaZPVvFDg/X0wZ4Si32aNACglV3mMniRdnd9oW7K9gH+Tj6GhjN8EA+TVZcCT57HVYZd1oXzzNb3KbVnNpVpRveM16qdgI99ty4enQ4jZJI/u9IHkezvogf2f0TuaIq6SCVaDH2nXfMQ+yJ79Io43772ySW1DhDe79LPaO+NHzE5qNqzHtZ1TMhH8tBq2cCLcZ9KN2btuxNS2yHnX2DKITH82t/Jz9xyILl2wkj3FV7UXHtJmKZ4RwecvvZmNZhnIVIzU4T7mpu+VLDymdVezw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 22 Feb 2022 12:10:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.02.2022 12:47, Andrew Cooper wrote:
> Most IOMMU hooks are already altcall for performance reasons.  Convert the
> rest of them so we can harden all the hooks in Control Flow Integrity
> configurations.  This necessitates the use of iommu_{v,}call() in debug builds
> too.  Switch to using an ASSERT() as all forms should resolve to &iommu_ops.
> 
> Move the root iommu_ops from __read_mostly to __ro_after_init now that the
> latter exists.
> 
> Since c/s 3330013e6739 ("VT-d / x86: re-arrange cache syncing"), vtd_ops is
> not modified and doesn't need a forward declaration, so we can use
> __initconst_cf_clobber for both VT-d and AMD.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.