[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/70] x86/pv-shim: Don't modify the hypercall table


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 22 Feb 2022 17:24:57 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7NdjwQVYqTQok97A0/KcCSmBYeB9IWDJXx/VY5gpWZs=; b=N6ejXkQryEAEY5gYbfehho6PyE25HRcFd1LlhVCTNX7WjCsuTFBw3A99IXn5DCgYU678EYff6Ya7udtPe491cOoTGT7i8ytVoKJqsKRqUcJUhZLyleB+8fqsY169OmibvvHXthQ2jqVYb196dTS/kIJqpWRmcztLbFD6E3qpz14Muckqz60wPJHe0n9bkiJWh4TrfmgFKpaaDLF/BOS/otfXbrEDWEIxKnjUTFW99tL9S3QGO1t+rd5ZGKueYpb66bs2rahmEgx/TPExCimn9tnilFno5cFYRmcjEMlYMgua5KS7aLBv8R7QbYoFY6cPhcULyStVyDskQJh63T42RQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nt+PcRA+OSC/nLIsO/GRBFjrvV/R0tGL9Jqa5OGsjJBGjzJNJQCb95U0xye9VY2lImkeFFPs9IHcjaGtMcRwMmitAVhkggwhHwfL2nAj4ktNZavdXIaWlwo3SmqmoCdW2QtZccXmrdHoCY+ivqDyVWbi9mbeW2TgrBOfbGoV8HT1NGkE15elP7OmzSpPfxBillmKUNMQ3eKxXUrCjhfqtsSQuEJsP+hMuo7iPHQUeOerUnSuD21/AvxEz279GjeVqDnwX2HUACYwRQ3T75Lr1G7m5KVC0IX0iWRZ5MoFqWMQpdGWWsFoadEapdf3FE3qBZwggQOMoQhMN8TcZ5kTXg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 22 Feb 2022 16:25:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.02.2022 16:26, Andrew Cooper wrote:
> From: Juergen Gross <jgross@xxxxxxxx>
> 
> When running as pv-shim the hypercall is modified today in order to
> replace the functions for __HYPERVISOR_event_channel_op and
> __HYPERVISOR_grant_table_op hypercalls.
> 
> Change this to call the related functions from the normal handlers
> instead when running as shim. The performance implications are not
> really relevant, as a normal production hypervisor will not be
> configured to support shim mode, so the related calls will be dropped
> due to optimisation of the compiler.
> 
> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
> wrapper do_grant_table_op() needed, as in this case grant_table.c
> isn't being built.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> [Split out of series.  Make compile in isolation]
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

As said, somewhat hesitantly
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

"Make compile in isolation", while describing the changes which weren't
in Jürgen's original patch, is quite terse. But anyway.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.