[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 24 Feb 2022 15:16:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PM/GDhpfC64e+DXbihrc4fpa1OhHEQcfKhNwcLWZrhQ=; b=NOrLWH8Cd11JpvziSI/3VHmSoPRbzuk71vGt9SuMbX1kd1wtl0NeHn6nRhqfSFc45BiJ9T61vkJH0TDorYJBp595c0wyH98uI+Fwx5N6VHuImcLt+e5mbEaIOUNImf47JyTR0OCzM17H6B/gTC2d61hKzb7+ZIFHsW/Z/SkGPOkWlWwRaXodXFR63hz/SkpBtb7760JOL4AQn4p/ckD2R4YbCK/cLSt35uWKLY1+e7UsVhqBHItErYTcX8jYxZoNikWJGI+ymbimBqHB4IjUmJHQufjDVp4EP+bZYlVQjx4s39K2xkJokPKICTxA1IKKWt/cGio4p5cF4pceGP1O/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LOW/zDNk34gQKHntulfifCnAraKbj4so/acFxeh6iA6ffWr9zJHykQwO6Ywf6SBK8lKE1GX25sYVTIJJCnG7M12FhcEPMqrspmgxHL1Y6rV0Ad8vMsjof0A4fh8Y8oroQ+EthPU/jk0BJCkCwUjxxcGmuBJMo8XQJrC2qvmg5DS2OxrHPMiIN64afuIgH/C9blaik5UBv+tWZWxFRhYDcpedoxc8TUqOHrCIffeznkCc4q2i8i8TCiP6gjkjmVw+QFOVm08H0UUgmcwBcO2ogEDEITbLcVOlypHtRtH84fpWo4Cfy8E5BOMROoQ6SvZE6QUZ5chO2vr7KOnxuCjpag==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 24 Feb 2022 14:16:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.02.2022 18:29, Jane Malalane wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
>
> void vmx_vlapic_msr_changed(struct vcpu *v)
> {
> - int virtualize_x2apic_mode;
> + bool virtualize_x2apic_mode;
> struct vlapic *vlapic = vcpu_vlapic(v);
> unsigned int msr;
>
> virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
> cpu_has_vmx_virtual_intr_delivery) &&
> - cpu_has_vmx_virtualize_x2apic_mode );
> + v->domain->arch.hvm.assisted_x2apic );
Following from my comment on patch 1, I'd expect this to become a simple
assignment of v->domain->arch.hvm.assisted_x2apic (at which point the
local variable could go away), just like ...
> - if ( !cpu_has_vmx_virtualize_apic_accesses &&
> + if ( !v->domain->arch.hvm.assisted_xapic &&
> !virtualize_x2apic_mode )
> return;
... here.
> @@ -1124,9 +1125,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v,
> uint32_t leaf,
> * and wrmsr in the guest will run without VMEXITs (see
> * vmx_vlapic_msr_changed()).
> */
> - if ( cpu_has_vmx_virtualize_x2apic_mode &&
> - cpu_has_vmx_apic_reg_virt &&
> - cpu_has_vmx_virtual_intr_delivery )
> + if ( cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery
> &&
> + v->domain->arch.hvm.assisted_x2apic )
> res->a |= XEN_HVM_CPUID_X2APIC_VIRT;
While within the 80 cols limit, I think it would help readability if you
kept it at one sub-condition per line.
Jan
|